Uh oh!
There was an error while loading. Please reload this page.
Fix languages empty array - #20719
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
GretaDforce-pushed
the
fix/fix_languages_empty_array
branch
from
April 29, 2020 16:02
38a752a to
679c26eCompareUh oh!
There was an error while loading. Please reload this page.
GretaD
commented
Apr 30, 2020
ContributorAuthor
hmm, do we need to change also here? server/apps/settings/lib/Settings/Personal/PersonalInfo.php Lines 192 to 198 in b569f3c |
skjnldsvforce-pushed
the
fix/fix_languages_empty_array
branch
from
May 4, 2020 13:43
679c26e to
6727d07Compareskjnldsv
approved these changes
May 4, 2020
ChristophWurst
approved these changes
May 4, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Didn't test but code looks good
skjnldsv
commented
May 4, 2020
Member
/backport to stable18 |
GretaDforce-pushed
the
fix/fix_languages_empty_array
branch
from
May 4, 2020 17:07
9b68aa0 to
a8d1afcCompareGretaDforce-pushed
the
fix/fix_languages_empty_array
branch
2 times, most recently
from
May 4, 2020 17:19
9b68aa0 to
6213478CompareMorrisJobke
requested changes
May 6, 2020
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
CI failures:
There were 3 failures:
373 374 1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testGetUserDataAsAdmin
375 Failed asserting that two arrays are equal.
376 --- Expected
377 +++ Actual
378 @@ @@
379 'website' => 'website'
380 'twitter' => 'twitter'
381 'groups' => Array (...)
382 - 'language' => 'de'
383 + 'language' => null
384 'locale' => null
385 'backendCapabilities' => Array (...)
386 )
387 388 /drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:1019
389 390 2) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testGetUserDataAsSubAdminAndUserIsAccessible
391 Failed asserting that two arrays are equal.
392 --- Expected
393 +++ Actual
394 @@ @@
395 'website' => 'website'
396 'twitter' => 'twitter'
397 'groups' => Array ()
398 - 'language' => 'da'
399 + 'language' => null
400 'locale' => null
401 'backendCapabilities' => Array (...)
402 )
403 404 /drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:1149
405 406 3) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testGetUserDataAsSubAdminSelfLookup
407 Failed asserting that two arrays are equal.
408 --- Expected
409 +++ Actual
410 @@ @@
411 'website' => 'website'
412 'twitter' => 'twitter'
413 'groups' => Array ()
414 - 'language' => 'ru'
415 + 'language' => null
416 'locale' => null
417 'backendCapabilities' => Array (...)
418 )
419 420 /drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:1319
421 422 --
rullzer
commented
May 6, 2020
Member
/backport to stable19 |
GretaDforce-pushed
the
fix/fix_languages_empty_array
branch
from
May 7, 2020 15:47
6213478 to
cf401e8CompareMorrisJobke
approved these changes
May 8, 2020
Signed-off-by: GretaD <gretadoci@gmail.com>
MorrisJobkeforce-pushed
the
fix/fix_languages_empty_array
branch
from
May 8, 2020 08:04
cf401e8 to
fce716bCompare
This was referenced May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When the language is forced an error occurs:
this happens because the forcedLanguage returns empty array.
Should be backported to 18 too