Skip to content

PHP 7.4 excludes the arguments from stack traces by default. - #20749

Merged
nickvergessen merged 2 commits into
masterfrom
bug/noid/is-not-setup-via-query-false-positive
May 4, 2020
Merged

PHP 7.4 excludes the arguments from stack traces by default.#20749
nickvergessen merged 2 commits into
masterfrom
bug/noid/is-not-setup-via-query-false-positive

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.

Runs only if debug => true.
ini_set seems to ignore non existing $vars: https://3v4l.org/DP4Lg

@kesselbkesselb added bug 3. to review Waiting for reviews labels Apr 30, 2020
@kesselbkesselb added this to the Nextcloud 19 milestone Apr 30, 2020
Comment threadlib/public/AppFramework/App.php Outdated
@rullzerrullzer mentioned this pull request Apr 30, 2020
11 tasks
@kesselb
kesselbforce-pushed the bug/noid/is-not-setup-via-query-false-positive branch from 434c5ba to e1d48f8CompareApril 30, 2020 14:33
That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the bug/noid/is-not-setup-via-query-false-positive branch from e1d48f8 to cba7219CompareApril 30, 2020 15:02
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@rullzerrullzer mentioned this pull request Apr 30, 2020
2 tasks

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickvergessen
nickvergessen merged commit afc5966 into masterMay 4, 2020
@nickvergessen
nickvergessen deleted the bug/noid/is-not-setup-via-query-false-positive branch May 4, 2020 07:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@nickvergessen@ChristophWurst