Uh oh!
There was an error while loading. Please reload this page.
Do not process the same shares twice - #20771
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, GretaD, gary-kim, georgehrke, juliusknorr and rullzerMay 1, 2020 13:16
rullzer
commented
May 1, 2020
Member
/compile amend / |
skjnldsvforce-pushed
the
fix/sharing-reactivity
branch
from
May 1, 2020 13:29
f9ff454 to
fa208aeCompareskjnldsv
commented
May 1, 2020
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
fix/sharing-reactivity
branch
from
May 1, 2020 13:32
fa208ae to
37182b0CompareSigned-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
fix/sharing-reactivity
branch
from
May 1, 2020 13:40
37182b0 to
31172a0Compareskjnldsv
commented
May 1, 2020
MemberAuthor
I'm wondering if we should backport 🤔 |
MorrisJobke
commented
May 8, 2020
Member
Let's leave it in 19 for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shares are processed twice. Vue is smart to not replace the whole data.
So when it's updated again, the share objects are changed but because the share id is the same, vue don't care and does not refresh everything (specifically the reactive state) and the objects references break....