Uh oh!
There was an error while loading. Please reload this page.
Improve group queries - #20776
Merged
Merged
Conversation
kesselb
reviewed
May 1, 2020
Uh oh!
There was an error while loading. Please reload this page.
Before we'd also get the diplayname for each group in the backend. In a separate query. This is of course not ideal as this information is obtained on each and every query. Now this is queried once and properly cached. Also added more caching to the manager. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
enh/limit_group_queries
branch
from
May 2, 2020 08:13
cf5eb75 to
5ebb535Comparerullzer
requested review from
ChristophWurst, MorrisJobke, danxuliu, icewind1991, kesselb and nickvergessenMay 7, 2020 07:23
MorrisJobke
commented
May 8, 2020
Member
I guess this one here solves already part of the issue: #20815 |
rullzer
commented
May 8, 2020
MemberAuthor
| $this->groupCache[$row['gid']] = $row['gid']; | ||
| $this->groupCache[$row['gid']] = [ | ||
| 'gid' => $row['gid'], | ||
| 'displayname' => $row['displayname'], |
There was a problem hiding this comment.
it this always displayname? I had this issue in Mail recently and I went for selectAlias to ensure the database does not return the selected column, like g.displayname
MemberAuthor
There was a problem hiding this comment.
but there is only 1 displayname... so it should not prefix it right?
rullzer
commented
May 21, 2020
MemberAuthor
One more review please :) |
juliusknorr
approved these changes
May 22, 2020
juliusknorr
commented
May 22, 2020
Member
php-cs check failure seems unrelated to that change 😉 |
rullzer
commented
May 22, 2020
MemberAuthor
I guess a backport makes sense here. At least to stable19 for 19.0.1 |
rullzer
commented
May 22, 2020
MemberAuthor
/backport to stable19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we'd also get the diplayname for each group in the backend. In a
separate query. This is of course not ideal as this information is
obtained on each and every query. Now this is queried once and properly
cached.
Also added more caching to the manager.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl