Uh oh!
There was an error while loading. Please reload this page.
Fix filtering our owner & current user from shares - #20825
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, MorrisJobke, georgehrke, juliusknorr and rullzerMay 5, 2020 10:18
skjnldsv
commented
May 5, 2020
MemberAuthor
/compile amend / |
skjnldsv
commented
May 5, 2020
MemberAuthor
/backport to stable18 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
fix/sharing-own-group
branch
from
May 5, 2020 10:28
c31fd8d to
edecd09Comparerullzer
approved these changes
May 5, 2020
georgehrke
approved these changes
May 5, 2020
gary-kim
approved these changes
May 5, 2020
skjnldsv
commented
May 5, 2020
MemberAuthor
Failures not related, fixing in different pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't check against share type === USER, we will also exclude groups that have the same uid than you or the owner. 🙈