Skip to content

Do not filter id matching userId on non-user-share shares - #20832

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/sharing-filter-user-shares-only-fix-group-display
May 6, 2020
Merged

Do not filter id matching userId on non-user-share shares#20832
MorrisJobke merged 1 commit into
masterfrom
fix/sharing-filter-user-shares-only-fix-group-display

Conversation

@skjnldsv

@skjnldsvskjnldsv commented May 5, 2020

Copy link
Copy Markdown
Member

Regression from #15952

Before
Kazam_screenshot_00018


After
Kazam_screenshot_00017

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@skjnldsv
skjnldsvforce-pushed the fix/sharing-filter-user-shares-only-fix-group-display branch from cf00e1c to c1c40b3CompareMay 5, 2020 17:00
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/sharing-filter-user-shares-only-fix-group-display branch from c1c40b3 to eb68aecCompareMay 5, 2020 17:13
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php
@skjnldsv
skjnldsvforce-pushed the fix/sharing-filter-user-shares-only-fix-group-display branch from eb68aec to 2cdd427CompareMay 5, 2020 18:06
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not build with production

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/sharing-filter-user-shares-only-fix-group-display branch from 2cdd427 to 3c7d9bbCompareMay 5, 2020 19:24
@nickvergessen

Copy link
Copy Markdown
Member

Lint / php-cs check (pull_request) Failing

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/sharing-filter-user-shares-only-fix-group-display branch from 3c7d9bb to a26ca1eCompareMay 5, 2020 19:37
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Lint / php-cs check (pull_request) Failing

fixed

@rullzerrullzer mentioned this pull request May 6, 2020
3 tasks

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke
MorrisJobke merged commit 06732cf into masterMay 6, 2020
@MorrisJobke
MorrisJobke deleted the fix/sharing-filter-user-shares-only-fix-group-display branch May 6, 2020 15:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@nickvergessen@MorrisJobke@ChristophWurst