Uh oh!
There was an error while loading. Please reload this page.
Fix color-text-maxcontrast not passing WCAG AA - #20853
Merged
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
skjnldsv
approved these changes
May 7, 2020
marcoambrosini
approved these changes
May 7, 2020
rullzer
approved these changes
May 7, 2020
rullzer
commented
May 7, 2020
Member
/backport to stable19 |
1 similar comment
jancborchardt
commented
May 9, 2020
MemberAuthor
/backport to stable19 |
jancborchardt
commented
May 9, 2020
MemberAuthor
/backport to stable18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intended value is #767676 on white, as per the comment at https://github.com/nextcloud/server/blob/master/core/css/variables.scss#L60
This stems from when I changed the color-main-text from #000 to #222 but didn’t adjust the lighten percentage. We should also backport this to 19, right?
@skjnldsv I would additionally say since the values are so similar, we limit the text variables to just color-main-text and color-text-maxcontrast. I would make both "light" and "lighter" map to "color-text-maxcontrast" for compatibility.