Uh oh!
There was an error while loading. Please reload this page.
macOS contacts: prefer personal over app generated - #20860
Merged
georgehrke merged 2 commits intoMay 8, 2020
Merged
Conversation
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
requested review from
ChristophWurst and rullzer
and removed request for
rullzerMay 7, 2020 14:38
georgehrke
commented
May 7, 2020
MemberAuthor
/backport stable19 |
georgehrke
commented
May 7, 2020
MemberAuthor
While the sabre/dav docs say that the one addressbook limitation affect only |
…rts only one and will pick the first one alphabetically Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrkeforce-pushed
the
bugfix/noid/macos_contacts_sync_prefer_personal_over_app-generated
branch
from
May 7, 2020 14:48
53fb7ff to
cbbe11fCompareChristophWurst
approved these changes
May 8, 2020
georgehrke
commented
May 8, 2020
MemberAuthor
Test failures unrelated, merging |
georgehrke
deleted the
bugfix/noid/macos_contacts_sync_prefer_personal_over_app-generated
branch
May 8, 2020 10:03
georgehrke
commented
May 8, 2020
MemberAuthor
/backport to stable19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://sabre.io/dav/clients/osx-addressbook/
This PR is adding support for ctag:
This PR renames
app-generatedtoz-app-generated:tl;dr:
Without this PR, macOS Contacts will only show the 5 contacts from the contacts interaction addressbook, but all the contacts from the personal addressbook will be gone.