Uh oh!
There was an error while loading. Please reload this page.
Use random_bytes - #20915
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, georgehrke and nickvergessenMay 11, 2020 08:33
georgehrke
approved these changes
May 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
Since we don't care if it is human readbale. The code is backwards compatible with the old format. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
enh/use_random_bytes_in_crypto
branch
from
May 11, 2020 10:47
421f78d to
35ff4aaComparenickvergessen
approved these changes
May 11, 2020
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Didn't test, but looks good.
nickvergessen
commented
May 11, 2020
Member
Backport till 17? |
rullzer
commented
May 11, 2020
MemberAuthor
sounds good! |
rullzer
commented
May 11, 2020
MemberAuthor
/backport to stable19 |
rullzer
commented
May 11, 2020
MemberAuthor
/backport to stable18 |
rullzer
commented
May 11, 2020
MemberAuthor
/backport to stable17 |
ChristophWurst
approved these changes
May 11, 2020
This was referenced May 11, 2020
lynn-stephenson
commented
Jun 18, 2020
Contributor
Glad to see this issue was fixed! :D |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't care if it is human readbale.
The code is backwards compatible with the old format.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl