Skip to content

[stable17] Enable fseek for files in S3 storage - #20966

Merged
MorrisJobke merged 5 commits into
stable17from
backport/20033/stable17
May 25, 2020
Merged

[stable17] Enable fseek for files in S3 storage#20966
MorrisJobke merged 5 commits into
stable17from
backport/20033/stable17

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented May 14, 2020•
edited by MorrisJobke
Loading

Copy link
Copy Markdown

backport of #20033

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 17.0.7 milestone May 14, 2020
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews bug labels May 14, 2020
@rullzerrullzer mentioned this pull request May 21, 2020
Merged
3 tasks
@kesselb

kesselb commented May 21, 2020

Copy link
Copy Markdown
Contributor

I would backport #20385 as well.

ahtiand others added 5 commits May 22, 2020 15:31
@ahti@MorrisJobke
Enable fseek for files in S3 storage
4611577
Signed-off-by: Lukas Stabe <lukas@stabe.de>
@icewind1991@MorrisJobke
make seekable s3 stream generic
2ecf23a
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991@MorrisJobke
add basic tests for s3 seeking and add some error handling if reopen …
2356088
…return the wrong range
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991@MorrisJobke
update autoloader
44ea3b8
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991@MorrisJobke
harden seekable http stream a bit against failures
e471c37
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
MorrisJobkeforce-pushed the backport/20033/stable17 branch from c90a4e3 to e471c37CompareMay 22, 2020 13:31
@MorrisJobke

MorrisJobke commented May 22, 2020

Copy link
Copy Markdown
Member

I would backport #20385 as well.

Added here as well.

MorrisJobke
MorrisJobke approved these changes May 22, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobkeMorrisJobke mentioned this pull request May 22, 2020
Merged
@MorrisJobke

MorrisJobke commented May 22, 2020

Copy link
Copy Markdown
Member

I redid the backport manually and the conflict was only due to changed array() to [] syntax. So this is a clean backport.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 22, 2020
@MorrisJobkeMorrisJobke mentioned this pull request May 25, 2020
Merged
@MorrisJobke
MorrisJobke merged commit 27486cf into stable17May 25, 2020
@MorrisJobke
MorrisJobke deleted the backport/20033/stable17 branch May 25, 2020 11:47
@MorrisJobkeMorrisJobke mentioned this pull request May 25, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991
@kesselbkesselbAwaiting requested review from kesselb
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 17.0.7

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@MorrisJobke@rullzer@ahti@icewind1991