Uh oh!
There was an error while loading. Please reload this page.
use the loginname to verify the old password in user password changes - #21106
Merged
Conversation
ChristophWurst
approved these changes
May 26, 2020
ChristophWurst
commented
May 26, 2020
Member
backports? |
MorrisJobke
approved these changes
May 26, 2020
MorrisJobke
commented
May 26, 2020
Member
CI fails |
rullzer
approved these changes
May 26, 2020
blizzz
commented
May 26, 2020
MemberAuthor
I'll check later today |
blizzz
commented
May 26, 2020
MemberAuthor
/backport to stable19 |
blizzz
commented
May 26, 2020
MemberAuthor
/backport to stable18 |
blizzz
commented
May 26, 2020
MemberAuthor
/backport to stable17 |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/10809/user-pwd-change-loginname
branch
from
May 26, 2020 14:53
92d1f0e to
653162aCompareblizzz
commented
May 26, 2020
MemberAuthor
Ha, there the tests were hidden. Expected them in a different location. Should pass now :) |
This was referenced May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For user driven password changes, the controller was using the uid instead of the login name to verify the current password. The login name must be used instead. While it does not play a matter for local backends, e.g. LDAP environments do suffer and often end fail with misleading "wrong password".
fixes#10809