Skip to content

Move systemtags to a proper location - #21118

Merged
rullzer merged 1 commit into
masterfrom
td/move_systemtags
May 29, 2020
Merged

Move systemtags to a proper location#21118
rullzer merged 1 commit into
masterfrom
td/move_systemtags

Conversation

@rullzer

Copy link
Copy Markdown
Member

Found when trying to move #20970 forward

  • use webpack handlebars loader
  • use own escapeHTML

@rullzerrullzer added 2. developing Work in progress technical debt 🧱 🤔🚀 labels May 26, 2020
@rullzerrullzer added this to the Nextcloud 20 milestone May 26, 2020
@rullzer
rullzerforce-pushed the td/move_systemtags branch from 7423737 to 9ac9379CompareMay 28, 2020 12:15
@rullzer

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@rullzer

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@rullzer

Copy link
Copy Markdown
MemberAuthor

/compile amend /

* Move to the handlebar loader from webpack
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 28, 2020

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍

@rullzer
rullzer merged commit efd025c into masterMay 29, 2020
@rullzer
rullzer deleted the td/move_systemtags branch May 29, 2020 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@georgehrke@ChristophWurst