Uh oh!
There was an error while loading. Please reload this page.
[stable18] simplify getGroups, fixing wrong chunking logic - #21129
Merged
Conversation
backportbot-nextcloudBot
requested review from
ChristophWurst, MorrisJobke, blizzz, juliusknorr and rullzerMay 27, 2020 17:40
ChristophWurst
requested changes
May 28, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Looks like essential parts of the original patch are missing
blizzz
commented
May 28, 2020
Member
changes lost were due to code style differences |
pagination is taken care of properly in the search logic in Access class Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
backport/21123/stable18
branch
from
May 28, 2020 18:13
7aaf5fa to
5f1cfbcCompareblizzz
approved these changes
May 28, 2020
MorrisJobke
commented
May 28, 2020
Member
I guess this has to wait for 18.0.6, right? |
blizzz
commented
May 29, 2020
Member
yes, no urgency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #21123