Skip to content

Fix reference to wrong class name - #21146

Merged
rullzer merged 1 commit into
masterfrom
fix-reference-to-wrong-class-name
May 29, 2020
Merged

Fix reference to wrong class name#21146
rullzer merged 1 commit into
masterfrom
fix-reference-to-wrong-class-name

Conversation

@danxuliu

Copy link
Copy Markdown
Member

Follow up to #20726

\OCP\IShare does not exist; the right name is \OCP\Share\IShare, although it is already imported as IShare.

\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliudanxuliu added this to the Nextcloud 20 milestone May 28, 2020
@danxuliu

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 29, 2020
@rullzer
rullzer merged commit ca606ce into masterMay 29, 2020
@rullzer
rullzer deleted the fix-reference-to-wrong-class-name branch May 29, 2020 06:46
@MorrisJobke

Copy link
Copy Markdown
Member

Why not backport down to 17 because the linked PR was also backported down to 17?

@danxuliu

Copy link
Copy Markdown
MemberAuthor

Why not backport down to 17 because the linked PR was also backported down to 17?

Because the backports to 17 and 18 were only partial backports and they do not include the change that is fixed here :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@danxuliu@MorrisJobke@rullzer