Uh oh!
There was an error while loading. Please reload this page.
Fix empty 'more' apps navigation after installing an app - #21173
Merged
Conversation
jancborchardt
requested review from
georgehrke, juliusknorr, kesselb, marcoambrosini and skjnldsvJune 1, 2020 00:21
skjnldsv
approved these changes
Jul 17, 2020
jancborchardt
commented
Jul 19, 2020
MemberAuthor
Any idea about how to make the app icons visible too @juliushaertl@skjnldsv? |
marcoambrosini
approved these changes
Jul 20, 2020
marcoambrosini
approved these changes
Jul 20, 2020
skjnldsv
commented
Jul 20, 2020
Member
no idea, this is Julius's expertise area :) |
jancborchardt
commented
Jul 28, 2020
MemberAuthor
So can we merge this for now as it already fixes the main issue? :) Not sure what the issue with Drone is, the report seems not to be found? |
kesselb
commented
Jul 28, 2020
Contributor
@jancborchardt if you rebase the branch drone will run another time. |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardtforce-pushed
the
design/navigation-install
branch
from
August 5, 2020 15:39
dc065dd to
42a265cComparejancborchardt
commented
Aug 6, 2020
MemberAuthor
The only test which failed was "cancelled" – not sure it would run if we restart and it might clog up the queue: https://drone.nextcloud.com/nextcloud/server/31428/14/5 |
MorrisJobke
commented
Aug 11, 2020
Member
/backport to stable19 |
MorrisJobke
commented
Aug 11, 2020
Member
/backport to stable18 |
MorrisJobke
commented
Aug 11, 2020
Member
/backport to stable17 |
This was referenced Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this old issue with the "More apps" list looking empty after adding a new app.
(The issue with the app icons not being visible still exists. The ones in the "More apps" list would have to be inverted to be black in the light theme and white in the dark theme. But I can’t see how to easily fix this – maybe @juliushaertl?)