Skip to content

Reflect unreadable state in the UI - #21185

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/reflect-unreadable-state-in-ui
Jun 10, 2020
Merged

Reflect unreadable state in the UI#21185
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/reflect-unreadable-state-in-ui

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 2, 2020

Copy link
Copy Markdown
Member

When you have an external mount point mounted that is not readable, we mark them gray in the UI to avoid unnecessary clicks

@nickvergessennickvergessen added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Jun 2, 2020
@nickvergessennickvergessen added this to the Nextcloud 20 milestone Jun 2, 2020
GretaD
GretaD approved these changes Jun 5, 2020
View reviewed changes

@GretaDGretaD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, but i dont know how to test it

@nickvergessen
Reflect unreadable state in the UI
31e9ab4
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Jun 10, 2020

Copy link
Copy Markdown
MemberAuthor
  1. Create a folder
  2. Apply a tag to it
  3. Enable "files_accesscontrol"
  4. Set up a workflow to block access on the tag of "2."
  5. Check your file list

@nickvergessen

nickvergessen commented Jun 10, 2020

Copy link
Copy Markdown
MemberAuthor

Rebased, lets get this in

@nickvergessen
nickvergessenforce-pushed the bugfix/noid/reflect-unreadable-state-in-ui branch from a4284e1 to 31e9ab4CompareJune 10, 2020 07:37
@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 10, 2020
@nickvergessen
nickvergessen merged commit 83303ef into masterJun 10, 2020
@nickvergessen
nickvergessen deleted the bugfix/noid/reflect-unreadable-state-in-ui branch June 10, 2020 08:54
@nickvergessen

nickvergessen commented Jun 10, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 10, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@GretaDGretaDGretaD approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.feature: files

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ChristophWurst@GretaD