Skip to content

Bump doctrine/dbal from 2.9.2 to 2.10.2 - #21208

Merged
rullzer merged 2 commits into
masterfrom
dependabot/composer/doctrine/dbal-2.10.2
Jun 9, 2020
Merged

Bump doctrine/dbal from 2.9.2 to 2.10.2#21208
rullzer merged 2 commits into
masterfrom
dependabot/composer/doctrine/dbal-2.10.2

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jun 3, 2020•
edited
Loading

Copy link
Copy Markdown
Member

For #16876

After ages this will pull in my upstream patch doctrine/dbal#3843

@ChristophWurstChristophWurst added this to the Nextcloud 20 milestone Jun 3, 2020
@ChristophWurstChristophWurst self-assigned this Jun 3, 2020
yarons
yarons approved these changes Jun 3, 2020
View reviewed changes

@yaronsyarons left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what to do but I approve.

@ChristophWurst
ChristophWurstforce-pushed the dependabot/composer/doctrine/dbal-2.10.2 branch from fd5b15d to 18bea3fCompareJune 4, 2020 07:42
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2020
@gary-kimgary-kim mentioned this pull request Jun 5, 2020
Closed
@rullzer

rullzer commented Jun 5, 2020

Copy link
Copy Markdown
Member

CI says no https://drone.nextcloud.com/nextcloud/server/29482/10/4

@nickvergessen

nickvergessen commented Jun 5, 2020

Copy link
Copy Markdown
Member

Fix is in nextcloud/3rdparty#452

@nickvergessennickvergessen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jun 5, 2020
@ChristophWurst
Bump doctrine/dbal from 2.9.2 to 2.10.2
3151945
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the dependabot/composer/doctrine/dbal-2.10.2 branch from c7bc914 to 3151945CompareJune 5, 2020 09:48
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 5, 2020
@ChristophWurst

ChristophWurst commented Jun 5, 2020

Copy link
Copy Markdown
MemberAuthor

Fixed. Thanks a lot.

@nickvergessen

nickvergessen commented Jun 5, 2020

Copy link
Copy Markdown
Member

There were 8 failures:

Fun!

@nickvergessennickvergessen mentioned this pull request Jun 8, 2020
Closed
@nickvergessen
Remove dropped " ON " when join has no condition
c68718f
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Jun 8, 2020

Copy link
Copy Markdown
Member

Fixed

@ChristophWurst

ChristophWurst commented Jun 8, 2020

Copy link
Copy Markdown
MemberAuthor

CI is not fully done but looks promising 🙏

@rullzer
rullzer merged commit de35da3 into masterJun 9, 2020
@rullzer
rullzer deleted the dependabot/composer/doctrine/dbal-2.10.2 branch June 9, 2020 09:08
@ChristophWurstChristophWurst mentioned this pull request Jun 9, 2020
Closed
@MorrisJobkeMorrisJobke mentioned this pull request Aug 14, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@yaronsyaronsyarons approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@kesselbkesselbAwaiting requested review from kesselb
@lihua-meowlihua-meowAwaiting requested review from lihua-meow
@GrotaxGrotaxAwaiting requested review from Grotax
@richardhjrichardhjAwaiting requested review from richardhj
@danjpgriffindanjpgriffinAwaiting requested review from danjpgriffin

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewsfeature: dependencies

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@rullzer@nickvergessen@yarons