Skip to content

Move humanFileSize and OC.getCanonicalLocale to npm packages - #21225

Merged
rullzer merged 1 commit into
masterfrom
techdebt/humanfilesize-getcanonicallocale-package
Jun 5, 2020
Merged

Move humanFileSize and OC.getCanonicalLocale to npm packages#21225
rullzer merged 1 commit into
masterfrom
techdebt/humanfilesize-getcanonicallocale-package

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jun 4, 2020

Copy link
Copy Markdown
Member

@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 pending documentation This pull request needs an associated documentation update labels Jun 4, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 20 milestone Jun 4, 2020
@ChristophWurstChristophWurst self-assigned this Jun 4, 2020
rullzer
rullzer requested changes Jun 4, 2020
View reviewed changes
Comment threadcore/src/OC/l10n.js Outdated
rullzer
rullzer approved these changes Jun 4, 2020
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristophWurst
ChristophWurstforce-pushed the techdebt/humanfilesize-getcanonicallocale-package branch from babe7d6 to d48b091CompareJune 4, 2020 09:39
@ChristophWurst

ChristophWurst commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2020
@rullzer

rullzer commented Jun 5, 2020

Copy link
Copy Markdown
Member

Conflicts....

@ChristophWurst
Move humanFileSize and OC.getCanonicalLocale to npm packages
eaf4724
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the techdebt/humanfilesize-getcanonicallocale-package branch from d48b091 to eaf4724CompareJune 5, 2020 06:49
@ChristophWurst

ChristophWurst commented Jun 5, 2020

Copy link
Copy Markdown
MemberAuthor

Rebased

@ChristophWurst

ChristophWurst commented Jun 5, 2020

Copy link
Copy Markdown
MemberAuthor

CI was happy btw (esp jsunit), so this should be good to merge

@rullzer
rullzer merged commit 81f83d3 into masterJun 5, 2020
@rullzer
rullzer deleted the techdebt/humanfilesize-getcanonicallocale-package branch June 5, 2020 07:02
This was referenced Oct 6, 2020
Merged
Merged
@ChristophWurst

ChristophWurst commented Oct 6, 2020

Copy link
Copy Markdown
MemberAuthor

Docs at nextcloud/documentation#5185

@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 6, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@georgehrkegeorgehrkegeorgehrke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@caugnercaugnerAwaiting requested review from caugner
@ahstroahstroAwaiting requested review from ahstro
@stefan-niedermannstefan-niedermannAwaiting requested review from stefan-niedermann
@korelstarkorelstarAwaiting requested review from korelstar
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@rullzer@georgehrke@juliusknorr