Skip to content

Enable passwordless for everyone not only admins. - #21274

Merged
rullzer merged 1 commit into
masterfrom
bug/21268/paswordless-for-everyone
Jun 7, 2020
Merged

Enable passwordless for everyone not only admins.#21274
rullzer merged 1 commit into
masterfrom
bug/21268/paswordless-for-everyone

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Adding NoSubadminRequired looks safe to me. start, finish and delete uses the current user session only.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added bug 3. to review Waiting for reviews labels Jun 6, 2020
@kesselbkesselb added this to the Nextcloud 20 milestone Jun 6, 2020
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable19

@kesselbkesselb linked an issue Jun 6, 2020 that may be closed by this pull request
@rullzer

Copy link
Copy Markdown
Member

Ah my bad... I was sure I tested it also with normal users. But they indeed might have been subadmins :S.....

@JanDragonJanDragon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rullzer
rullzer merged commit ce7a15e into masterJun 7, 2020
@rullzer
rullzer deleted the bug/21268/paswordless-for-everyone branch June 7, 2020 13:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add WebAuthn-device in NC 19

3 participants

@kesselb@rullzer@JanDragon