Skip to content

Init fileinfo for all tabs - #21306

Merged
rullzer merged 1 commit into
stable18from
fix/stable18/sidebar-tabs-update
Jun 9, 2020
Merged

Init fileinfo for all tabs#21306
rullzer merged 1 commit into
stable18from
fix/stable18/sidebar-tabs-update

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jun 8, 2020

Copy link
Copy Markdown
Member

After #20564

No idea why this works on master, reactivity seems to behave better.
Anyway, it works now™

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews high javascript feature: file sidebar Related to the file sidebar component 18-feedback labels Jun 8, 2020
@skjnldsvskjnldsv added this to the Nextcloud 18.0.6 milestone Jun 8, 2020
@skjnldsvskjnldsv self-assigned this Jun 8, 2020
@skjnldsv

skjnldsv commented Jun 8, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsv@npmbuildbot
Init fileinfo for all tabs
366ee97
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/stable18/sidebar-tabs-update branch from c909320 to 366ee97CompareJune 8, 2020 11:03
@rullzerrullzer mentioned this pull request Jun 8, 2020
Closed
@kklem0
kklem0 self-requested a review June 8, 2020 11:13
@kesselbkesselb linked an issue Jun 8, 2020 that may be closed by this pull request
[Updating to 18.0.5.] The document does not display versions, comments, events. (Sidebar) #21239
Closed
kesselb
kesselb approved these changes Jun 8, 2020
View reviewed changes

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@go2sh

go2sh commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

This commit is the reason, why it works on master an stable19. As I said old nextcloud-vue version...

@kklem0

kklem0 commented Jun 8, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

This commit is the reason, why it works on master an stable19. As I said old nextcloud-vue version...

Just to make sure, this commit was also in stable18 as nextcloud-libraries/nextcloud-vue@ee18269, but I'm probably missing something.

go2sh
go2sh approved these changes Jun 8, 2020
View reviewed changes

@go2shgo2sh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an freshly checkout instance of the branche and activity app. Fixes both the old issue and my regression. Sorry for that...

@go2sh

go2sh commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

@clementhk Hmm okay, maybe you are right. I just saw during my debugging, that the watched fileProp function I use, was not part of the actualy fileProp object watcher list and so the loaded fileProp did not propagate to the tabs :(

@rullzerrullzer mentioned this pull request Jun 8, 2020
Merged
1 task
@kklem0

kklem0 commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

@clementhk Hmm okay, maybe you are right. I just saw during my debugging, that the watched fileProp function I use, was not part of the actualy fileProp object watcher list and so the loaded fileProp did not propagate to the tabs :(

So if we can confirm that stable19/master actually work and don't need porting, we could either just go with this (everything works for me so I guess no harm there) or we could try to find out which commit made stable19/master work and backport it to keep consistency?

@rullzer
rullzer merged commit 149d471 into stable18Jun 9, 2020
@rullzer
rullzer deleted the fix/stable18/sidebar-tabs-update branch June 9, 2020 07:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@go2shgo2shgo2sh approved these changes
@kklem0kklem0kklem0 approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@kesselbkesselbkesselb approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugfeature: file sidebarRelated to the file sidebar componenthighjavascript

Projects

None yet

Milestone

Nextcloud 18.0.6

Development

Successfully merging this pull request may close these issues.

[Updating to 18.0.5.] The document does not display versions, comments, events. (Sidebar)

6 participants

@skjnldsv@go2sh@kklem0@rullzer@juliusknorr@kesselb