Skip to content

Deprecate \OCP\IServerContainer::getEventDispatcher - #21322

Merged
rullzer merged 1 commit into
masterfrom
techdebt/deprecate-iservercontainer-geteventdispatcher
Jun 9, 2020
Merged

Deprecate \OCP\IServerContainer::getEventDispatcher#21322
rullzer merged 1 commit into
masterfrom
techdebt/deprecate-iservercontainer-geteventdispatcher

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jun 8, 2020

Copy link
Copy Markdown
Member

No description provided.

@ChristophWurst
Deprecate \OCP\IServerContainer::getEventDispatcher
fec3fef
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Jun 8, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 20 milestone Jun 8, 2020
@ChristophWurstChristophWurst self-assigned this Jun 8, 2020
@ChristophWurstChristophWurst mentioned this pull request Jun 8, 2020
Closed
@ChristophWurst

ChristophWurst commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

I had a deja vu when I changed this. Turns out I did this for the implementation already in 18

server/lib/private/Server.php

Line 2030 in 6aa6ab3

* @deprecated 18.0.0 use \OCP\EventDispatcher\IEventDispatcher
. I guess due to my mistake I'll have to now wait three years until this can be removed, or do we accept a retroactive deprecation, like updating this to 18 here and backporting the annotation?

@rullzer
rullzer merged commit 3f07485 into masterJun 9, 2020
@rullzer
rullzer deleted the techdebt/deprecate-iservercontainer-geteventdispatcher branch June 9, 2020 08:32
@ChristophWurstChristophWurst mentioned this pull request Jul 15, 2020
Merged
@ChristophWurst

ChristophWurst commented Oct 6, 2020

Copy link
Copy Markdown
MemberAuthor

Documented in nextcloud/documentation#5160

@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 6, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@kesselbkesselbkesselb approved these changes
@blizzzblizzzAwaiting requested review from blizzz

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@rullzer@nickvergessen@juliusknorr@kesselb