Skip to content

Dashboard API - #21346

Merged
rullzer merged 17 commits into
masterfrom
enh/20930/dashboard
Jul 15, 2020
Merged

Dashboard API#21346
rullzer merged 17 commits into
masterfrom
enh/20930/dashboard

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jun 9, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This PR is the first part of the planned dashboard work. For now it contains the following parts:

  • Deprecating the old dashboard API
  • Add a simplified new API as proposed in Dashboard overview #20930
  • Add a new dashboard app that mainly takes care of providing dom elements so that apps can render their own views into it.

A reference panel implementation can be found in nextcloud/recommendations#229

Required steps for implementing a panel as an app developer: 📖 nextcloud/documentation#2168

ToDo

Follow-up

  • Implement dynamic sorting and adding/removing panels (follow up PR)
  • App store category for apps supporting dashboard (follow up PR)
  • Check if we can make the default app dynamic depending on a user setting (follow up PR)
  • Decide if this should be the default app and how the order of apps should be in the app menu (follow up PR)
  • Updating Nextcloud with the new Dashboard app and the old one installed will need Use shipped.json file from new release updater#255 to make sure the app is properly replaced
    • With a spearate app directory, using the same app id as the current dashboard app should not be an issue if we have a higher app version available

ChristophWurst
ChristophWurst reviewed Jun 9, 2020
View reviewed changes
Comment threadapps/dashboard/lib/Controller/DashboardController.php Outdated
@rullzerrullzer added the 2. developing Work in progress label Jun 10, 2020
@jancborchardt

jancborchardt commented Jun 11, 2020

Copy link
Copy Markdown
Member

Great work, added some design & layout fixes. Now just needs the panels (or mocks) for Calendar, Mail and Talk. :)

ChristophWurst
ChristophWurst reviewed Jun 16, 2020
View reviewed changes
Comment threadapps/dashboard/src/App.vue Outdated
@juliusknorr
juliusknorrforce-pushed the enh/20930/dashboard branch 2 times, most recently from 30a3f3a to 4ab2dc5CompareJune 23, 2020 15:05
@juliusknorrjuliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 23, 2020
@juliusknorr
juliusknorr marked this pull request as ready for review June 23, 2020 15:28
@juliusknorr

juliusknorr commented Jun 23, 2020

Copy link
Copy Markdown
MemberAuthor

Acceptance tests would still need some more work due to the new default app, but this should be good for a first review round until those are figured out. 😉

ChristophWurst
ChristophWurst reviewed Jun 23, 2020
View reviewed changes
Comment threadapps/dashboard/appinfo/info.xml
Comment threadapps/dashboard/lib/Controller/DashboardController.php Outdated
Comment threadapps/dashboard/lib/Controller/DashboardController.php
Comment threadapps/dashboard/src/App.vue Outdated
Comment threadlib/public/Dashboard/IManager.php Outdated
Comment threadlib/public/Dashboard/IPanel.php
Comment threadlib/public/Dashboard/IRegisterPanelEvent.php Outdated
@rullzer

rullzer commented Jun 24, 2020

Copy link
Copy Markdown
Member

Acceptance tests would still need some more work due to the new default app, but this should be good for a first review round until those are figured out. wink

Maybe as discussed we don't add it as default just yet. only when we think it is ready?

@juliusknorr

juliusknorr commented Jun 24, 2020

Copy link
Copy Markdown
MemberAuthor

Maybe as discussed we don't add it as default just yet. only when we think it is ready?

Yes, I've dropped that for now and added it to the todo list for the next steps.

@juliusknorr

juliusknorr commented Jun 24, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

This was referenced Jun 24, 2020
Merged
Merged
ChristophWurst
ChristophWurst requested changes Jun 25, 2020
View reviewed changes
Comment threadlib/private/Dashboard/Manager.php
@juliusknorrjuliusknorr mentioned this pull request Jun 26, 2020
Merged
9 tasks
ChristophWurst
ChristophWurst approved these changes Jun 26, 2020
View reviewed changes
Comment threadlib/private/Dashboard/Manager.php
ChristophWurst
ChristophWurst reviewed Jun 26, 2020
View reviewed changes
Comment threadlib/public/Dashboard/IPanel.php
juliusknorrand others added 16 commits July 15, 2020 09:24
@juliusknorr
Add new dashboard public API
673d70d
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Deprecate old dashboard API
544fcdb
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add dashboard app
5a18749
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jancborchardt@juliusknorr
Modify dashboard welcome sentences
4b9d47f
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt@juliusknorr
Fix Dashboard layout, positioning and responsiveness
829bf1a
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@juliusknorr
Separate icon from translatable text
a0cd760
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Update autoloader
86a7d16
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Move to lazy panel registration during registration context
81e5593
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Deprecate panel register event right away but keep it for not breakin…
f7c04b0
…g backward compatible apps
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Initialize panels early to make sure that scripts can be loaded
66ce9ed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Cleanup public api methods
b71de68
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jancborchardt@juliusknorr
Update Dashboard app icon
879b756
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@juliusknorr
Add load method for apps to bootstrap their panels
31a1494
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Load more than one panel
e6fb1b9
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Dashboard strict typing
35bdb99
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Include name in translatable greeting
0c35218
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the enh/20930/dashboard branch 2 times, most recently from 053f7cf to 1026be8CompareJuly 15, 2020 07:33
@juliusknorr

juliusknorr commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@juliusknorr
Bump bundles
6b2bb32
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

juliusknorr commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

Ah it was the missing map file.

@rullzer
rullzer merged commit f04f932 into masterJul 15, 2020
@rullzer
rullzer deleted the enh/20930/dashboard branch July 15, 2020 09:10
@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

Breaks master tests - let me fix them.

MorrisJobke added a commit that referenced this pull request Jul 15, 2020
@MorrisJobke
Fix integration test due to new dashboard app
8dd48f3
See #21346
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke mentioned this pull request Jul 15, 2020
Merged
@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

Breaks master tests - let me fix them.

#21849

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@juliusknorr@jancborchardt@rullzer@MorrisJobke@nickvergessen@ChristophWurst@skjnldsv@MarkPartlett