Skip to content

Fix modal support for vue apps - #21417

Merged
nickvergessen merged 5 commits into
masterfrom
bugfix/noid/modal-support-for-vue-apps
Jun 17, 2020
Merged

Fix modal support for vue apps#21417
nickvergessen merged 5 commits into
masterfrom
bugfix/noid/modal-support-for-vue-apps

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 15, 2020

Copy link
Copy Markdown
Member
  • Fixes missing modal background for vue apps #content vs .content
  • Makes confirmDestructive a modal by default
  • Makes the modal darkmode compatible (black overlaying black is not too useful, so I use the font color now)
BeforeAfter
Bildschirmfoto von 2020-06-15 17-00-36Bildschirmfoto von 2020-06-15 17-00-25

@nickvergessen
Fix modal support for vue apps
b1f74b0
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the confirm dialog modal by default
be0ecbc
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add darkmode support for the modal background
b514030
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Rebuild JS files
2d96e89
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 20 milestone Jun 15, 2020
@nickvergessennickvergessen mentioned this pull request Jun 15, 2020
Merged
@nickvergessen

nickvergessen commented Jun 15, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@nickvergessen

nickvergessen commented Jun 15, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

ChristophWurst
ChristophWurst approved these changes Jun 15, 2020
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

gary-kim
gary-kim approved these changes Jun 15, 2020
View reviewed changes

@gary-kimgary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

jancborchardt
jancborchardt approved these changes Jun 15, 2020
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

skjnldsv
skjnldsv reviewed Jun 16, 2020
View reviewed changes
Comment threadcore/src/jquery/css/jquery.ocdialog.scss Outdated
skjnldsv
skjnldsv approved these changes Jun 16, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, otherwise good! 👍

jancborchardt
jancborchardt requested changes Jun 16, 2020
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call with the 0.8 instead of 0.2 overlay – looks much better than a bright backdrop.

Comment threadcore/src/jquery/css/jquery.ocdialog.scss Outdated
@nickvergessen
Darker background for dark mode
eca3c9f
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 17, 2020
jancborchardt
jancborchardt approved these changes Jun 17, 2020
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! :)

@nickvergessen
nickvergessen merged commit ee59029 into masterJun 17, 2020
@nickvergessen
nickvergessen deleted the bugfix/noid/modal-support-for-vue-apps branch June 17, 2020 13:35
@backportbot-nextcloud

backportbot-nextcloudBot commented Jun 17, 2020

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jun 17, 2020

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

This was referenced Jun 23, 2020
Merged
Merged
@nickvergessen

nickvergessen commented Jun 23, 2020

Copy link
Copy Markdown
MemberAuthor

Backports done manually:
#21541
#21543

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@gary-kimgary-kimgary-kim approved these changes
@rmanibusrmanibusAwaiting requested review from rmanibus
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: accessibility

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@jancborchardt@ChristophWurst@skjnldsv@gary-kim