Skip to content

getXbyY can still return false, e.g. when using ldap write support - #21421

Merged
blizzz merged 2 commits into
masterfrom
fix/noid/cached-missing-dn
Jun 19, 2020
Merged

getXbyY can still return false, e.g. when using ldap write support#21421
blizzz merged 2 commits into
masterfrom
fix/noid/cached-missing-dn

Conversation

@blizzz

@blizzzblizzz commented Jun 15, 2020

Copy link
Copy Markdown
Member

To reproduce:

  1. have ldap_write_support on master (e.g. from update tests and bump max version ldap_write_support#165)
  2. try to create a user
  3. You'll get an error message and an exception logged saying "Translation to LDAP DN unsuccessful"

@blizzz
getXbyY can still return false, e.g. when using ldap write support
0cf57d1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 20 milestone Jun 15, 2020
@blizzz

blizzz commented Jun 15, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

ChristophWurst
ChristophWurst requested changes Jun 16, 2020
View reviewed changes
Comment threadapps/user_ldap/lib/Mapping/AbstractMapping.php Outdated
@blizzz@ChristophWurst
be more clear about the condition
0ab6ee4
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
@blizzz
blizzz merged commit 976dbf6 into masterJun 19, 2020
@blizzz
blizzz deleted the fix/noid/cached-missing-dn branch June 19, 2020 18:01
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jun 19, 2020
Merged
@blizzzblizzz mentioned this pull request Jun 19, 2020
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@kklem0kklem0kklem0 approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@rubo77rubo77Awaiting requested review from rubo77

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@ChristophWurst@kklem0