Uh oh!
There was an error while loading. Please reload this page.
Allow to specify the cookie type for appframework responses - #21479
Merged
Conversation
rullzer added a commit
to nextcloud/user_saml
that referenced
this pull request
Jun 19, 2020
Requires nextcloud/server#21479 to fully work. Basically don't save this info in the session (which is lax by default starting with NC19 but also soon with new chromes and firefox). We now save it is a cookie that is set to None. This is the best we can do I think. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This was referenced Jun 19, 2020
kesselb
commented
Jun 19, 2020
Contributor
Needs an update. |
kesselb
reviewed
Jun 19, 2020
Uh oh!
There was an error while loading. Please reload this page.
kesselb
approved these changes
Jun 19, 2020
blizzz
reviewed
Jun 19, 2020
Uh oh!
There was an error while loading. Please reload this page.
blizzz
reviewed
Jun 19, 2020
Uh oh!
There was an error while loading. Please reload this page.
In general it is good to set them to Lax. But also to give devs more control over them is not a bad thing. Helps with #21474 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/21474/allow_specifying_cookie_type
branch
from
June 22, 2020 06:38
d299f74 to
fbf9772Comparejuliusknorr
approved these changes
Jun 22, 2020
blizzz
commented
Jun 22, 2020
Member
/backport to stable19 |
rullzer added a commit
to nextcloud/user_saml
that referenced
this pull request
Jul 7, 2020
Requires nextcloud/server#21479 to fully work. Basically don't save this info in the session (which is lax by default starting with NC19 but also soon with new chromes and firefox). We now save it is a cookie that is set to None. This is the best we can do I think. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer added a commit
to nextcloud/user_saml
that referenced
this pull request
Jul 10, 2020
Requires nextcloud/server#21479 to fully work. Basically don't save this info in the session (which is lax by default starting with NC19 but also soon with new chromes and firefox). We now save it is a cookie that is set to None. This is the best we can do I think. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer added a commit
to nextcloud/user_saml
that referenced
this pull request
Jul 10, 2020
Requires nextcloud/server#21479 to fully work. Basically don't save this info in the session (which is lax by default starting with NC19 but also soon with new chromes and firefox). We now save it is a cookie that is set to None. This is the best we can do I think. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
maxbes pushed a commit
to Worteks/user_saml
that referenced
this pull request
Aug 10, 2020
Requires nextcloud/server#21479 to fully work. Basically don't save this info in the session (which is lax by default starting with NC19 but also soon with new chromes and firefox). We now save it is a cookie that is set to None. This is the best we can do I think. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.
Helps with #21474
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl