Skip to content

show better error messages when a file with a forbidden path is encountered - #21484

Merged
MorrisJobke merged 1 commit into
masterfrom
better-forbidden-path-errors
Mar 25, 2021
Merged

show better error messages when a file with a forbidden path is encountered#21484
MorrisJobke merged 1 commit into
masterfrom
better-forbidden-path-errors

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 2. developing Work in progress label Jun 19, 2020

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

@PVince81

Copy link
Copy Markdown
Member

@icewind1991 still developing though and no reviewers pinged ? anything open ?

…ntered
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the better-forbidden-path-errors branch from e6fe51e to aee4caeCompareMarch 24, 2021 16:13
@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2021
@icewind1991icewind1991 added this to the Nextcloud 22 milestone Mar 24, 2021
@icewind1991

Copy link
Copy Markdown
MemberAuthor

rebased and ready for review

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2021
@MorrisJobke
MorrisJobke merged commit ad16b19 into masterMar 25, 2021
@MorrisJobke
MorrisJobke deleted the better-forbidden-path-errors branch March 25, 2021 08:15
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@PVince81@MorrisJobke