Skip to content

acceptence tests shall specify which branch to pick when cloning apps - #21492

Merged
rullzer merged 1 commit into
masterfrom
fix/noid/branch-for-cloning-acceptance-related-apps
Jun 21, 2020
Merged

acceptence tests shall specify which branch to pick when cloning apps#21492
rullzer merged 1 commit into
masterfrom
fix/noid/branch-for-cloning-acceptance-related-apps

Conversation

@blizzz

Copy link
Copy Markdown
Member

they fail currently for in stable18 and 19. Customized backports follow manually.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/noid/branch-for-cloning-acceptance-related-apps branch from 9986dbf to de61c7dCompareJune 19, 2020 19:09

@gary-kimgary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we take the result of git rev-parse --abbrev-ref HEAD instead so this doesn't have to be set manually when new stable versions are made?

EDIT: Whoops, just realized what the issue with that would be 🙈

@rullzer
rullzer merged commit d7157bb into masterJun 21, 2020
@rullzer
rullzer deleted the fix/noid/branch-for-cloning-acceptance-related-apps branch June 21, 2020 07:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@rullzer@danxuliu@gary-kim