Uh oh!
There was an error while loading. Please reload this page.
fix strings being passed where arrays where expected - #21576
Merged
Conversation
also brought type hints up to internal API level Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, juliusknorr, kesselb, mx2s and rullzerJune 24, 2020 21:38
blizzz
commented
Jun 24, 2020
MemberAuthor
/backport to stable19 |
juliusknorr
approved these changes
Jun 25, 2020
mx2s
approved these changes
Jun 25, 2020
ChristophWurst
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#21464 – type hints where not expected by a callee. Because internal API didn't enforce them, usage went through unnoticed.