Skip to content

Bye bye database xml - #21641

Merged
rullzer merged 2 commits into
masterfrom
techdebt/noid/bye-bye-database-xml
Mar 25, 2021
Merged

Bye bye database xml#21641
rullzer merged 2 commits into
masterfrom
techdebt/noid/bye-bye-database-xml

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@nickvergessennickvergessen added this to the Nextcloud 20 milestone Jun 30, 2020
@nickvergessen
nickvergessenforce-pushed the techdebt/noid/bye-bye-database-xml branch from 6be4bc3 to 569975eCompareJuly 1, 2020 06:26
nickvergessen
nickvergessen commented Jul 1, 2020
View reviewed changes
Comment threadlib/private/Installer.php
@nickvergessennickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 2, 2020
MorrisJobke
MorrisJobke approved these changes Jul 6, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

This was referenced Jul 6, 2020
Merged
Closed
@nickvergessen
nickvergessenforce-pushed the techdebt/noid/bye-bye-database-xml branch from 87c6d9e to 2316080CompareJuly 7, 2020 17:21
@MorrisJobkeMorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@MorrisJobke

MorrisJobke commented Aug 13, 2020

Copy link
Copy Markdown
Member

Something for 21

@rullzerrullzer mentioned this pull request Dec 14, 2020
Merged
59 tasks
@nickvergessen

nickvergessen commented Dec 14, 2020

Copy link
Copy Markdown
MemberAuthor

Should merge/redo after 21 is branched off.

@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Dec 14, 2020
@ChristophWurstChristophWurst mentioned this pull request Dec 14, 2020
Merged
@PVince81

PVince81 commented Mar 17, 2021

Copy link
Copy Markdown
Member

a wild group of conflicts appeared

@nickvergessen

nickvergessen commented Mar 24, 2021

Copy link
Copy Markdown
MemberAuthor

yeah, anyone can feel free to take over and re do it.
I'm currently lacking the time to do so

@MorrisJobkeMorrisJobke self-assigned this Mar 24, 2021
@MorrisJobke

MorrisJobke commented Mar 24, 2021

Copy link
Copy Markdown
Member

The first two commits are already handled by #24247. Let me continue there.

@MorrisJobke

MorrisJobke commented Mar 24, 2021

Copy link
Copy Markdown
Member

b156cf8 is handled in #24035

@MorrisJobkeMorrisJobke mentioned this pull request Mar 24, 2021
Closed
@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/bye-bye-database-xml branch from 2316080 to 4851efdCompareMarch 24, 2021 19:02
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 24, 2021
@nickvergessen@MorrisJobke
Bye bye database.xml
bb0c507
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/bye-bye-database-xml branch from 4851efd to bb0c507CompareMarch 24, 2021 19:04
@MorrisJobkeMorrisJobke mentioned this pull request Mar 24, 2021
Open
@MorrisJobke

MorrisJobke commented Mar 24, 2021

Copy link
Copy Markdown
Member

I just cleaned up a bit behind the removal of the usage of database.xml and removed all the helper classes (and their tests). 🧹

@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/bye-bye-database-xml branch from 25316f1 to 6b9a765CompareMarch 24, 2021 20:45
@MorrisJobke
Cleanup unneeded code around database.xml
ab48d5e
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the techdebt/noid/bye-bye-database-xml branch from 6b9a765 to ab48d5eCompareMarch 24, 2021 21:15
MorrisJobke
MorrisJobke approved these changes Mar 24, 2021
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side 🚀

rullzer
rullzer approved these changes Mar 25, 2021
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@rullzer
rullzer merged commit c15172b into masterMar 25, 2021
@rullzer
rullzer deleted the techdebt/noid/bye-bye-database-xml branch March 25, 2021 07:58
@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jul 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gary-kimgary-kimgary-kim left review comments
@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbAwaiting requested review from kesselb

Assignees

@MorrisJobkeMorrisJobke

Labels

3. to reviewWaiting for reviewsfeature: install and updatetechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@MorrisJobke@PVince81@rullzer@ChristophWurst@gary-kim