Skip to content

Do not target vue progressbar with server styles - #21810

Merged
marcoambrosini merged 1 commit into
masterfrom
do-not-target-vue-progress-bar-with-server-styles
Jan 25, 2021
Merged

Do not target vue progressbar with server styles#21810
marcoambrosini merged 1 commit into
masterfrom
do-not-target-vue-progress-bar-with-server-styles

Conversation

@marcoambrosini

Copy link
Copy Markdown
Member

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

Comment threadcore/css/inputs.scss Outdated
@marcoambrosini
marcoambrosiniforce-pushed the do-not-target-vue-progress-bar-with-server-styles branch 2 times, most recently from fc92d17 to 157532dCompareJuly 13, 2020 13:42
@skjnldsv

Copy link
Copy Markdown
Member

I don't understand why.
Why would we need a vue component for this?

@marcoambrosini

Copy link
Copy Markdown
MemberAuthor

So? Are we getting this in?

@skjnldsv

Copy link
Copy Markdown
Member

Sure, I'm not fond of this, but let get this in :)

@marcoambrosini

Copy link
Copy Markdown
MemberAuthor

Erhm.. Do you know why tests are failing?

@nickvergessen

Copy link
Copy Markdown
Member

Drone history is gone, try a rebase on master

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini
marcoambrosiniforce-pushed the do-not-target-vue-progress-bar-with-server-styles branch from 157532d to dc9d37eCompareJanuary 25, 2021 08:22
@marcoambrosini

Copy link
Copy Markdown
MemberAuthor

done!

@marcoambrosini
marcoambrosini merged commit a4ed9e7 into masterJan 25, 2021
@marcoambrosini
marcoambrosini deleted the do-not-target-vue-progress-bar-with-server-styles branch January 25, 2021 15:04
@rullzerrullzer mentioned this pull request Jan 27, 2021
19 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@marcoambrosini@skjnldsv@nickvergessen@juliusknorr