Skip to content

Add real events to load additionalscripts - #21822

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/events/additionalscripts
Jul 15, 2020
Merged

Add real events to load additionalscripts#21822
MorrisJobke merged 1 commit into
masterfrom
enh/events/additionalscripts

Conversation

@rullzer

@rullzerrullzer commented Jul 13, 2020•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Jul 13, 2020
@rullzerrullzer added this to the Nextcloud 20 milestone Jul 13, 2020
@MorrisJobke

MorrisJobke commented Jul 13, 2020

Copy link
Copy Markdown
Member

New events should be documented in https://docs.nextcloud.com/server/19/developer_manual/app/events.html#available-events and old deprecations need to be added to #20953

@MorrisJobke

MorrisJobke commented Jul 13, 2020

Copy link
Copy Markdown
Member

Please also fix the CS complains :)

This was referenced Jul 13, 2020
Merged
Merged
Merged
@rullzer
rullzerforce-pushed the enh/events/additionalscripts branch from 7f8d6b6 to 87d6d47CompareJuly 14, 2020 06:48
ChristophWurst
ChristophWurst requested changes Jul 14, 2020
View reviewed changes
Comment threadlib/public/AppFramework/Http/Events/LoadAdditionalScriptsEvent.php Outdated
Comment threadlib/public/AppFramework/Http/Events/LoadAdditionalScriptsLoggedInEvent.php Outdated
@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

Let me push some fixup commits here and then we can continue the discussion :)

@MorrisJobke
MorrisJobke requested a review from kesselbJuly 15, 2020 07:34
@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

@rullzer@ChristophWurst Give me your feedback :)

kesselb
kesselb reviewed Jul 15, 2020
View reviewed changes
Comment threadlib/private/AppFramework/Middleware/AdditionalScriptsMiddleware.php Outdated
@MorrisJobkeMorrisJobke added the pending documentation This pull request needs an associated documentation update label Jul 15, 2020
@MorrisJobke
MorrisJobkeforce-pushed the enh/events/additionalscripts branch 2 times, most recently from 201c8a4 to 6b5d76bCompareJuly 15, 2020 11:49
@rullzer@MorrisJobke
Add real events to load additionalscripts
7d7ba61
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke
MorrisJobkeforce-pushed the enh/events/additionalscripts branch from 6b5d76b to 7d7ba61CompareJuly 15, 2020 12:07
@rullzer

rullzer commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

🚀

@rullzer

rullzer commented Jul 15, 2020

Copy link
Copy Markdown
MemberAuthor

👍 from me

@MorrisJobke
MorrisJobke merged commit fc41810 into masterJul 15, 2020
@MorrisJobke
MorrisJobke deleted the enh/events/additionalscripts branch July 15, 2020 17:50
@MorrisJobkeMorrisJobke mentioned this pull request Jul 15, 2020
Merged
@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

nextcloud/documentation#2201

@MorrisJobke

MorrisJobke commented Jul 15, 2020

Copy link
Copy Markdown
Member

#14552 to remove the legacy handler at some point in time.

@ChristophWurstChristophWurst mentioned this pull request Jul 15, 2020
Closed
@MorrisJobkeMorrisJobke mentioned this pull request Jul 15, 2020
Merged
@MorrisJobkeMorrisJobke removed the pending documentation This pull request needs an associated documentation update label Jul 15, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@kesselbkesselbkesselb left review comments
@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@ChristophWurst@kesselb