Uh oh!
There was an error while loading. Please reload this page.
Build source maps on production build again - #21832
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
ChristophWurst, MorrisJobke, rullzer and skjnldsvJuly 14, 2020 11:56
juliusknorr
commented
Jul 14, 2020
MemberAuthor
/compile / |
juliusknorr
commented
Jul 14, 2020
MemberAuthor
/backport 506f178 to stable19 |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
MorrisJobke
approved these changes
Jul 14, 2020
ChristophWurst
approved these changes
Jul 14, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
I think this sets a new record on the ratio of source line changes vs bundle changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regresion from #21725 since we provide a custom TerserPlugin instance now it takes the defaults from https://github.com/webpack-contrib/terser-webpack-plugin#sourcemap now, which is why source maps were currently not built when running
npm run build.This should cause the CI to complain about outdated bundles. I'll compile once that happened ;)