Migrate files to the PSR container

[ChristophWurst]

📜 nextcloud/documentation#2202

• Requires Use PSR container interface and deprecate our own abstraction #21809

[ChristophWurst]

Files app still shows files 👍 🐨

[MorrisJobke]

files integration tests fail.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31848: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (18.157 secs / 15.875 secs)

sqlite

Show full log

There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1597650786 is equal to 1597650787 or is greater than 1597650787.
/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

acceptance-app-files

• tests/acceptance/features/app-files.feature:22
• tests/acceptance/features/app-files.feature:246
• tests/acceptance/features/app-files.feature:262
• tests/acceptance/features/app-files.feature:281
• tests/acceptance/features/app-files.feature:289

Show full log

 Scenario: open and close the details view again after coming back from a different section # /drone/src/tests/acceptance/features/app-files.feature:22
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I open the "Recent" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "Recent" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
Row for file welcome.txt in file list could not be found after 100 seconds
File actions menu button for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
When I open the "All files" section # AppNavigationContext::iOpenTheSection()
And I see that the current section is "All files" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
Then I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
Scenario: marking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:246
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
When I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
Then I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
Scenario: mark a file as favorite in the details view # /drone/src/tests/acceptance/features/app-files.feature:281
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
When I mark the file as favorite in the details view # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
Then I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()
Scenario: unmark a file as favorite in the details view # /drone/src/tests/acceptance/features/app-files.feature:289
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I mark the file as favorite in the details view # FilesAppContext::iMarkTheFileAsFavoriteInTheDetailsView()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
Favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that the file is marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView()
When I unmark the file as favorite in the details view # FilesAppContext::iUnmarkTheFileAsFavoriteInTheDetailsView()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
And I see that the file is not marked as favorite in the details view # FilesAppContext::iSeeThatTheFileIsNotMarkedAsFavoriteInTheDetailsView()

[MorrisJobke]

I fixed the name of the tag service and now also favoriting files works 👍