Bump @nextcloud/vue from 1.5.0 to 2.2.1 by georgehrke · Pull Request #21867 · nextcloud/server

georgehrke · 2020-07-16T12:25:10Z

Signed-off-by: Georg Ehrke developer@georgehrke.com

Breaking changes:

georgehrke · 2020-07-16T12:41:56Z

/compile /

skjnldsv · 2020-07-16T15:20:45Z

- </div>
- </AppNavigationSettings>
+ </template>
+ <template #footer>


Wait, why did we need a footer slot? I completely missed this! 🤔

https://github.com/nextcloud/nextcloud-vue/releases/tag/v2.2.0 😉

Interesting choice, I would have put the default slot to be the list and not the Navigation new button 🤷

skjnldsv

Thanks for this @georgehrke ❤️

skjnldsv · 2020-07-17T06:55:16Z

Needs big rebase.

georgehrke · 2020-07-17T07:05:32Z

Rebased

ChristophWurst · 2020-07-17T13:13:54Z

dependageorg

Nice

ChristophWurst

Not sure if ready to review but the code looks fine :)

skjnldsv · 2020-07-19T17:26:38Z

Acceptance apps/users fails & jsunit too.

georgehrke · 2020-07-20T07:08:55Z

PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
1011	PhantomJS 2.1.1 (Linux 0.0.0) ERROR
1012 {
1013 "message": "SyntaxError: Unexpected token 'const'\nat apps/files/js/dist/personal-settings.js:1:0",
1014 "str": "SyntaxError: Unexpected token 'const'\nat apps/files/js/dist/personal-settings.js:1:0"
1015 }
1016	PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 0 ERROR (0.374 secs / 0 secs)
1017	PhantomJS 2.1.1 (Linux 0.0.0) ERROR
1018 {
1019 "message": "SyntaxError: Unexpected token 'const'\nat apps/files/js/dist/sidebar.js:1:0",
1020 "str": "SyntaxError: Unexpected token 'const'\nat apps/files/js/dist/sidebar.js:1:0"
1021 }

skjnldsv · 2020-07-20T08:03:52Z

I guess this is the same issue I reported recently.
There is an issue loading the scripts on files on master 🤔

georgehrke · 2020-07-20T09:02:51Z

I guess this is the same issue I reported recently.
There is an issue loading the scripts on files on master 🤔

The nc/vue bundle seems to be using const in the built version. I added it to the webpack config.

skjnldsv · 2020-07-20T10:51:40Z

Transpile @nc/vue and some of its dependencies 2e6775b

I'm not sure abou tthis one! Don't we already transpile on the library?
https://github.com/nextcloud/nextcloud-vue/blob/master/babel.config.js

georgehrke · 2020-07-21T09:08:51Z

I'm not sure abou tthis one! Don't we already transpile on the library?
https://github.com/nextcloud/nextcloud-vue/blob/master/babel.config.js

I dug into this issue and turns out it is an issue in v-tooltip. Since version 2.0.3 it's shipping ES6 in the minified builds:
Akryum/floating-vue#466

The server is using v-tooltip 2.0.2, but nc/vue is already on 2.0.3

danxuliu · 2020-07-21T19:48:21Z

I have fixed the share link acceptance tests (basically the share menu was covering in some cases the Copy link button; it should not happen with up to date browsers).

However, while checking this I have found a small issue (latest Firefox):

Since nextcloud-libraries/nextcloud-vue@f3b223a the Actions menu is always shown to the top if there is enough room (before this was done only for centered menus, so it did not apply to the share menu due to being aligned to the right). However, as can be seen in this case there is not enough room, and yet the menu is still shown to the top (and a scroll bar is not shown either). I do not know if the problem is in the Vue component itself or in the way that it is used in the sharing tab.

skjnldsv · 2020-07-22T07:21:31Z

the problem is in the Vue component itself

this ^

georgehrke · 2020-07-22T10:42:39Z

the problem is in the Vue component itself
this ^

That seems to be an edge case with certain view heights.
@skjnldsv @rullzer Are you fine with merging this for now?

skjnldsv · 2020-07-22T11:12:08Z

@skjnldsv @rullzer Are you fine with merging this for now?

good for me :)

rullzer · 2020-07-22T13:47:23Z

the problem is in the Vue component itself
this ^
That seems to be an edge case with certain view heights.
@skjnldsv @rullzer Are you fine with merging this for now?

Yep lets do this. But be sure to create an issue so we don't lose track

georgehrke · 2020-07-22T13:49:05Z

Created an issue: nextcloud-libraries/nextcloud-vue#1215

Let me rebase

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

The (old) Firefox version used in the acceptance tests does not properly render the share link menu. As the menu is taller than it should sometimes it covers the copy link button, so it is not possible to click it without hiding the share link menu. Moreover, in those cases the share menu button is also covered by the share menu, so the menu needs to be closed by pressing the "Esc" key. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

faily-bot · 2020-07-22T14:58:21Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 30976: failure

mariadb10.1-php7.2

Show full log

There were 8 warnings:
1) Test\DB\DBSchemaTest::testSchema
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
2) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
3) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
4) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
5) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
6) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
7) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
8) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
assertArraySubset() is deprecated and will be removed in PHPUnit 9.
--
There was 1 failure:
1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #232 ('folder', 29, 13)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:367
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions
/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

mysql8.0-php7.2

Show full log

There were 8 warnings:
1) Test\DB\DBSchemaTest::testSchema
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
2) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
3) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
4) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
5) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
6) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
7) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
8) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
assertArraySubset() is deprecated and will be removed in PHPUnit 9.
--
There were 2 failures:
1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #165 ('folder', 13, 7)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:367
2) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'
/drone/src/apps/files_versions/tests/VersioningTest.php:729
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions
/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

georgehrke added the 2. developing Work in progress label Jul 16, 2020

georgehrke requested review from ChristophWurst, juliusknorr and skjnldsv July 16, 2020 13:27

skjnldsv reviewed Jul 16, 2020
View reviewed changes

skjnldsv approved these changes Jul 16, 2020
View reviewed changes

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch from 84a3da7 to 303fedbCompare July 17, 2020 07:05

georgehrke requested a review from rullzer July 17, 2020 11:20

georgehrke mentioned this pull request Jul 17, 2020
Status Feature #21186
Merged
3 tasks

ChristophWurst approved these changes Jul 17, 2020
View reviewed changes

georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2020

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch 2 times, most recently from d5406ba to 571bb49Compare July 20, 2020 08:54

skjnldsv added enhancement feature: dependencies high javascript 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 20, 2020

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch from 10c79d8 to 0698123Compare July 20, 2020 10:54

georgehrke added 3. to review Waiting for reviews 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews labels Jul 20, 2020

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch 2 times, most recently from c3bfb36 to 1f8aae4Compare July 21, 2020 06:44

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch from 1f8aae4 to a421723Compare July 21, 2020 10:36

georgehrke assigned danxuliu Jul 21, 2020

danxuliu removed their assignment Jul 21, 2020

georgehrke mentioned this pull request Jul 22, 2020
Wrong positioning of ActionsMenu nextcloud-libraries/nextcloud-vue#1215
Closed

georgehrkeand others added 4 commits July 22, 2020 15:55

Bump @nextcloud/vue from 1.5.0 to 2.2.1
b73aedb
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Fix breaking changes of nc/vue update
f217b11
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

Recompile JS assets
387b1d7
Signed-off-by: Georg Ehrke <developer@georgehrke.com>

georgehrke force-pushed the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch from cbf5a8c to 9303390Compare July 22, 2020 14:00

georgehrke requested a review from skjnldsv July 22, 2020 14:02

georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 22, 2020

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2020

skjnldsv merged commit 5fea50b into masterJul 22, 2020

skjnldsv deleted the dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 branch July 22, 2020 15:47

Uh oh!

Uh oh!

Conversation

georgehrke commented Jul 16, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

georgehrke commented Jul 16, 2020

Uh oh!

skjnldsvJul 16, 2020

Choose a reason for hiding this comment

Uh oh!

georgehrkeJul 16, 2020

Choose a reason for hiding this comment

Uh oh!

skjnldsvJul 17, 2020

Choose a reason for hiding this comment

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Jul 17, 2020

Uh oh!

georgehrke commented Jul 17, 2020

Uh oh!

ChristophWurst commented Jul 17, 2020

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Jul 19, 2020

Uh oh!

georgehrke commented Jul 20, 2020

Uh oh!

skjnldsv commented Jul 20, 2020

Uh oh!

georgehrke commented Jul 20, 2020

Uh oh!

skjnldsv commented Jul 20, 2020

Uh oh!

georgehrke commented Jul 21, 2020

Uh oh!

danxuliu commented Jul 21, 2020

Uh oh!

skjnldsv commented Jul 22, 2020

Uh oh!

georgehrke commented Jul 22, 2020

Uh oh!

skjnldsv commented Jul 22, 2020

Uh oh!

rullzer commented Jul 22, 2020

Uh oh!

georgehrke commented Jul 22, 2020

Uh oh!

faily-botBot commented Jul 22, 2020

Status of 30976: failure

mariadb10.1-php7.2

mysql8.0-php7.2

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

georgehrke commented Jul 16, 2020•
edited
Loading