Uh oh!
There was an error while loading. Please reload this page.
Use DOMContentLoaded and fix sharebymail loading issue - #21921
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/use-DOMContentLoaded
branch
from
July 20, 2020 10:42
6a6c8bd to
6fcd075Comparenpmbuildbot-nextcloudBotforce-pushed
the
fix/use-DOMContentLoaded
branch
from
July 20, 2020 10:43
6fcd075 to
52773e9Compareskjnldsvforce-pushed
the
fix/use-DOMContentLoaded
branch
from
July 20, 2020 10:44
52773e9 to
6fcd075Compareskjnldsv
commented
Jul 20, 2020
Comment on lines
+181
to
+185
| const capabilities = OC.getCapabilities() | ||
| // eslint-disable-next-line camelcase | ||
| return capabilities?.files_sharing?.sharebymail !== undefined | ||
| // eslint-disable-next-line camelcase | ||
| && capabilities?.files_sharing?.public?.enabled === true |
Merged
skjnldsv
commented
Jul 20, 2020
MemberAuthor
Failure unrelated :) |
juliusknorr
approved these changes
Jul 20, 2020
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Seems to do the trick with the random loading issues.
georgehrke
approved these changes
Jul 20, 2020
MorrisJobke
commented
Jul 20, 2020
Member
Oh! This makes the integration tests more reliable! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #20949