Respect default share permissions

[rullzer]

Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[rullzer]

/backport to stable19

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31006: failure

mariadb10.4-php7.3

Show full log

There were 8 warnings:
1) Test\DB\DBSchemaTest::testSchema
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
2) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
3) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
4) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
5) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
6) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
7) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
8) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreate
assertArraySubset() is deprecated and will be removed in PHPUnit 9.
--
There was 1 failure:
1) Test\Comments\ManagerTest::testGetForObjectSince with data set #7 (3, 'desc', 2, 1, 2)
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
- 0 => 3
- 1 => 2
+ 0 => 5
+ 1 => 4
)
/drone/src/tests/lib/Comments/ManagerTest.php:381
--
There was 1 risky test:
1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions
/drone/src/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php:115

mysql8.0-php7.2

• cancelled - typically means that the tests took longer than the drone CI allows them to run

[MorrisJobke]

/backport to stable18

[MorrisJobke]

See #21967 (comment)