Skip to content

[stable19] Fix risky test in twofactor_backupcodes - #21978

Merged
MorrisJobke merged 1 commit into
stable19from
backport/21973/stable19
Jul 24, 2020
Merged

[stable19] Fix risky test in twofactor_backupcodes#21978
MorrisJobke merged 1 commit into
stable19from
backport/21973/stable19

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #21973

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot

faily-botBot commented Jul 23, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31053: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

acceptance-header

  • tests/acceptance/features/header.feature:31
Show full log
 Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section of the "Administration" group # AppNavigationContext::iOpenTheSectionOf()
And I enable restricting username autocompletion to groups # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
And I see that username autocompletion is restricted to groups # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
Failed asserting that true is false.
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@MorrisJobke
MorrisJobke merged commit 874a1ef into stable19Jul 24, 2020
@MorrisJobke
MorrisJobke deleted the backport/21973/stable19 branch July 24, 2020 11:20
@rullzerrullzer mentioned this pull request Aug 13, 2020
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@MorrisJobke