Object store trashbin fixes

[icewind1991]

object stores are "special" given how they interact with the cache on their own

I'm not very happy about adding special cases like this but it's the best I can come up with

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31219: failure

mariadb10.4-php7.3

Show full log

There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #76 ('folder', 17, 19)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mysql5.6-php7.2

Show full log

There was 1 error:
1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testUpdate with data set #0 ('sharedBy', 'shareOwner')
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:481
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

This fixes a regression from #21628

[icewind1991]

/backport to stable19

[icewind1991]

/backport to stable18

[backportbot-nextcloud]

The backport to stable19 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable18 failed. Please do this backport manually.

[MorrisJobke]

Not needed - the big was introduced in the above linked pull request which wasn’t backported

[icewind1991]

there are backports for that, but those aren't merged yet.

I'll put this in the original backports instead

[MorrisJobke]

I'll put this in the original backports instead

👍