Skip to content

Fix browser freeze on long password input - #22087

Merged
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/browser-freeze-on-long-password-input
Aug 3, 2020
Merged

Fix browser freeze on long password input#22087
skjnldsv merged 1 commit into
masterfrom
bugfix/noid/browser-freeze-on-long-password-input

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@MorrisJobke

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobke

Copy link
Copy Markdown
Member

Sorry - actually needs a rebase 🙈

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/browser-freeze-on-long-password-input branch from 4ffb8e6 to d51f9fbCompareAugust 3, 2020 12:52
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Rebased

@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2020
@faily-bot

faily-botBot commented Aug 3, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31315: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:23
Show full log
 Scenario: share a file with another user that needs to accept shares # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section # AppNavigationContext::iOpenTheSection()
And I disable accepting the shares by default # SettingsContext::iDisableAcceptingTheSharesByDefault()
And I see that shares are not accepted by default # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I accept the share for "/farewell.txt" in the notifications # NotificationsContext::iAcceptTheShareForInTheNotifications()
Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "admin" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

@skjnldsv
skjnldsv merged commit 34c7ea3 into masterAug 3, 2020
@skjnldsv
skjnldsv deleted the bugfix/noid/browser-freeze-on-long-password-input branch August 3, 2020 14:39
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable17 failed. Please do this backport manually.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@skjnldsv