Add 'Reasons to use Nextcloud in your organization' call to action in settings by jancborchardt · Pull Request #22136 · nextcloud/server

jancborchardt · 2020-08-06T21:01:22Z

As discussed @karlitschek

Need a developer to take over or offer advice on:

Actually making the document open in the viewer / files_pdfviewer on click of the button, cc @juliushaertl @skjnldsv
Decide if the "skeleton" folder is the right place to put this – it’s the only folder with documents so I figured it’s as good as any, and will also make that file show up in a fresh dev instance which isn’t bad either.

(The file is not the final version yet as Marija and I are still polishing it up.)

karlitschek

great! 👍

jospoortvliet · 2020-08-11T13:53:42Z

Should the icon not be white, too? This grey looks a bit off...

jancborchardt · 2020-08-11T13:57:45Z

@jancborchardt yep it should, will adjust as soon as we have the final document :)

skjnldsv · 2020-08-12T10:19:22Z

Actually making the document open in the viewer / files_pdfviewer on click of the button, cc @juliushaertl @skjnldsv

files_pdfviewer is still not using viewer, so no idea what their api is

juliusknorr · 2020-08-12T10:45:45Z

files_pdfviewer is still not using viewer, so no idea what their api is

There is none most likely. Also using this will only work if the file is in the example files and not removed by the user. So I'd rather vote to use something like https://www.npmjs.com/package/vue-pdf and show it in a modal just for personal the settings.

skjnldsv · 2020-08-12T10:49:20Z

So I'd rather vote to use something like npmjs.com/package/vue-pdf and show it in a modal just for personal the settings.

How hard would it be to move to viewer 🙈 ?

EDIT: let me try to see that today for 20

jancborchardt · 2020-08-17T11:42:55Z

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

juliusknorr · 2020-08-17T12:04:22Z

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

~~Should be in https://github.com/nextcloud/example-files i think. ;)~~

Ah my bad, missed nextcloud/example-files#10

skjnldsv · 2020-08-17T12:54:23Z

Added the final pdf document to core/skeleton now, will have to hand this over then – to you @skjnldsv?

sure commit incoming

skjnldsv · 2020-08-17T20:16:56Z

A CSP issue, I asked Roeland for help 👍
Otherwise implementation is done with conditional rendering of the file is not in the user folder anymore!

rullzer · 2020-08-18T11:06:46Z

nextcloud/files_pdfviewer#201
The fix :)

rullzer · 2020-08-18T11:12:57Z

+	if (button) {
+ button.addEventListener('click', function() {
+ OCA.Viewer.open({
+ path: '/Reasons to use Nextcloud.pdf',


Will it actually be in your home folder?

According to skeleton, yes, no?

rullzer · 2020-08-18T11:13:39Z

@jancborchardt @karlitschek we allow admins to set custom skeleton files. In that case we have no way to link to the file. How would be open it then?

karlitschek · 2020-08-18T12:17:12Z

@rullzer Agreed. I think the file needs to live somewhere else. Not in the skeleton

jancborchardt · 2020-08-18T14:12:44Z

@jancborchardt @karlitschek we allow admins to set custom skeleton files. In that case we have no way to link to the file. How would be open it then?

Yes, as said I have no idea where to put it – I think it’s good to have it in example files and skeleton just to show it to devs and users. But yes, for it to properly work it also needs to live somewhere permanently → and that’s your call @rullzer.

rullzer · 2020-08-18T18:09:20Z

So actually putting the file somewhere we can. But the issue is a bit that I think the viewer is only build to handle opening from webdav. Which we can't if it is nto in your main files...

skjnldsv · 2020-08-19T08:39:01Z

But the issue is a bit that I think the viewer is only build to handle opening from webdav. Which we can't if it is nto in your main files...

Yep, only if it's within DAV

rullzer · 2020-08-19T14:23:46Z

Ok so that is a bit problematic then.

@jancborchardt else we just serve the file from a controller and people open it int he pdf app of their chosing... I think almost everybody can properly open pdfs.

rullzer · 2020-09-01T18:25:34Z

still conflicts :S

rullzer · 2020-09-03T20:30:26Z

/compile amend /

skjnldsv · 2020-09-04T17:59:03Z

Rebased ready to go

skjnldsv · 2020-09-04T19:34:37Z

So many failures

faily-bot · 2020-09-06T19:25:51Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32717: failure

mysql5.6-php7.2

Show full log

There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopy with data set #1 ('/source.txt', '/target with space.txt')
Expected /target with space.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.
/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:235

… settings Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

ChristophWurst · 2020-09-07T06:52:58Z

- "version": "7.10.5",
- "resolved": "https://registry.npmjs.org/@babel/cli/-/cli-7.10.5.tgz",
- "integrity": "sha512-j9H9qSf3kLdM0Ao3aGPbGZ73mEA9XazuupcS6cDGWuiyAcANoguhP0r2Lx32H5JGw4sSSoHG3x/mxVnHgvOoyA==",
+ "version": "7.11.5",


lots of packages were updated unintentionally 🐘

Sometimes done automatically :p
If it's deps of deps

Nope. Only if you npm update or npm i another dependency. But this doesn't happen just so.

@skjnldsv ?

No clue!
It's merged now 🤷

Then let's Yolo on! 🎉

MorrisJobke · 2020-09-07T16:05:09Z

@rullzer Psalm said no: #22650 😉

jospoortvliet · 2020-11-30T12:27:32Z

@jancborchardt yep it should, will adjust as soon as we have the final document :)

So sadly this made it into the release 🙈

#24450

jancborchardt added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Aug 6, 2020

jancborchardt added this to the Nextcloud 20 milestone Aug 6, 2020

jancborchardt requested review from juliusknorr, karlitschek and skjnldsv August 6, 2020 21:01

karlitschek approved these changes Aug 7, 2020
View reviewed changes

MorrisJobke mentioned this pull request Aug 11, 2020
20.0.0 Beta 1 #22188
Merged
57 tasks

jancborchardt force-pushed the design/reasons-to-use-nextcloud branch from e684e29 to 4cb9f25Compare August 17, 2020 11:41

jancborchardt mentioned this pull request Aug 17, 2020
Add 'Reasons to use Nextcloud.pdf' nextcloud/example-files#10
Merged

skjnldsv assigned skjnldsv and jancborchardt Aug 17, 2020

rullzer reviewed Aug 18, 2020
View reviewed changes

skjnldsv force-pushed the design/reasons-to-use-nextcloud branch from 73c1ffd to bcc27adCompare September 1, 2020 09:15

skjnldsv requested review from ChristophWurst, juliusknorr and rullzer September 1, 2020 09:15

npmbuildbot-nextcloudBotforce-pushed the design/reasons-to-use-nextcloud branch from bcc27ad to 423de69Compare September 1, 2020 09:27

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 1, 2020

rullzer mentioned this pull request Sep 3, 2020
20 beta 4 #22562
Merged
13 tasks

rullzer force-pushed the design/reasons-to-use-nextcloud branch 2 times, most recently from c2f583c to 95f0892Compare September 3, 2020 20:29

skjnldsv force-pushed the design/reasons-to-use-nextcloud branch from 95f0892 to 651f177Compare September 4, 2020 17:59

skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 4, 2020

rullzer force-pushed the design/reasons-to-use-nextcloud branch 3 times, most recently from d74bf5c to b25e6d1Compare September 6, 2020 18:11

skjnldsv approved these changes Sep 7, 2020
View reviewed changes

Add 'Reasons to use Nextcloud in your organization' call to action in…
4c48d6b
… settings Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>

rullzer force-pushed the design/reasons-to-use-nextcloud branch from b25e6d1 to 4c48d6bCompare September 7, 2020 06:30

rullzer merged commit 16e1d1c into masterSep 7, 2020

rullzer deleted the design/reasons-to-use-nextcloud branch September 7, 2020 06:49

ChristophWurst reviewed Sep 7, 2020
View reviewed changes

MorrisJobke mentioned this pull request Sep 7, 2020
Only load viewer in settings if the viewer app is enabled #22650
Merged

Uh oh!

Uh oh!

Conversation

jancborchardt commented Aug 6, 2020• edited by rullzer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karlitschek left a comment

Choose a reason for hiding this comment

Uh oh!

jospoortvliet commented Aug 11, 2020

Uh oh!

jancborchardt commented Aug 11, 2020

Uh oh!

skjnldsv commented Aug 12, 2020

Uh oh!

juliusknorr commented Aug 12, 2020

Uh oh!

skjnldsv commented Aug 12, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt commented Aug 17, 2020

Uh oh!

juliusknorr commented Aug 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Aug 17, 2020

Uh oh!

skjnldsv commented Aug 17, 2020

Uh oh!

rullzer commented Aug 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rullzer commented Aug 18, 2020

Uh oh!

karlitschek commented Aug 18, 2020

Uh oh!

jancborchardt commented Aug 18, 2020

Uh oh!

rullzer commented Aug 18, 2020

Uh oh!

skjnldsv commented Aug 19, 2020

Uh oh!

rullzer commented Aug 19, 2020

Uh oh!

rullzer commented Sep 1, 2020

Uh oh!

rullzer commented Sep 3, 2020

Uh oh!

skjnldsv commented Sep 4, 2020

Uh oh!

skjnldsv commented Sep 4, 2020

Uh oh!

faily-botBot commented Sep 6, 2020

Status of 32717: failure

mysql5.6-php7.2

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Sep 7, 2020

Uh oh!

jospoortvliet commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

jancborchardt commented Aug 6, 2020•
edited by rullzer
Loading

skjnldsv commented Aug 12, 2020•
edited
Loading

juliusknorr commented Aug 17, 2020•
edited
Loading