add personal addtional setting section

[dassio]

in the developer manual settings section, there is a mentioning of additional default section, but it only appears on the admin part, not on the person part. resulting in apps that are meant for non-admin users can not use the default additional section, this pull request is to add the personal default Additional settings

[dassio]

are there anyone who can help to review this one ?

[ChristophWurst]

Fine by me :)

[juliusknorr]

There seems to be an issue that the section will still be shown empty if no additional settings are available, could you look into that again?

[juliusknorr]

Ah seems to be related to the this settings class:

server/apps/settings/lib/Settings/Personal/Additional.php

Line 30 in 41b5e59

class Additional implements ISettings {

[dassio]

Ah seems to be related to the this settings class:

server/apps/settings/lib/Settings/Personal/Additional.php

Line 30 in 41b5e59

class Additional implements ISettings {

@ChristophWurst , can we delete this empty setting, or we have any paticular reason to keep it ?

[dassio]

@juliushaertl@rullzer@kesselb please help to review
I deleted the empty personal setting view

[dassio]

can we merge this one now? I just did a rebase on master

[juliusknorr]

I'm not entirely sure about the complete removal yet, as it was a fallback for old settings registration iirc, so this would need to be checked if it still works.

[dassio]

you are correct

I tried with this app Ebook Reader 1.4.2, is we remove this, we can't find the setting anymore
I will add it back

[dassio]

I reverted it back and fix the duplicate addtional issue, not sure how to make the empty addtional go away

[kesselb]

There seems to be an issue that the section will still be shown empty if no additional settings are available, could you look into that again?

Sounds like #22144@juliushaertl@nickvergessen 🤔

[dassio]

blank addtional section removed @kesselb

[kesselb]

blank addtional section removed @kesselb

Sorry. I don't know much about the settings area. It was not my intention to request changes. I just noticed the other pull requested and added a hint. We have to wait for the other reviews to specify the expected behaviour and how those pull requests work together.

[dassio]

solved by #22589

[nickvergessen]

Sorry @dassio I didn't see your PR before creating mine, and since the one line diff on my is easier I guess that is why it got merged. Thanks for the work anyway!

[nickvergessen]

this is because there is no an personal addtional section in the settings app, shouldn't we add the section instead of hacking the system ? it will make later comer much eaiser to understand the structure.

While I agree in general, the one liner is much easier to be backported. So let's make it properly (like in the admin section?) with your PR, and only do the minimal impact PR for the backporting