Skip to content

Generate password on addUser by password_policy app - #22159

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/22014/generate-passwords-policy
Aug 10, 2020
Merged

Generate password on addUser by password_policy app#22159
MorrisJobke merged 1 commit into
masterfrom
enh/22014/generate-passwords-policy

Conversation

@kesselb

@kesselbkesselb commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

Fix#22014, Based on #22028

Emit a event to let the password policy app generate a secure password if enabled.

@kesselbkesselb added 3. to review Waiting for reviews enhancement labels Aug 9, 2020
@kesselbkesselb added this to the Nextcloud 20 milestone Aug 9, 2020
@kesselb
kesselbforce-pushed the enh/22014/generate-passwords-policy branch from 44f7cce to 73c2b68CompareAugust 9, 2020 15:06
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the enh/22014/generate-passwords-policy branch from 73c2b68 to c19bdb0CompareAugust 9, 2020 16:38
@faily-bot

faily-botBot commented Aug 9, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31541: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@MorrisJobke
MorrisJobke merged commit ccb1675 into masterAug 10, 2020
@MorrisJobke
MorrisJobke deleted the enh/22014/generate-passwords-policy branch August 10, 2020 13:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password policy validation fail for new users

3 participants

@kesselb@rullzer@MorrisJobke