Skip to content

Remove unexpected argument - #22176

Merged
MorrisJobke merged 1 commit into
masterfrom
debt/noid/table-render-too-many-arguments
Aug 11, 2020
Merged

Remove unexpected argument#22176
MorrisJobke merged 1 commit into
masterfrom
debt/noid/table-render-too-many-arguments

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 10, 2020
@kesselbkesselb added this to the Nextcloud 20 milestone Aug 10, 2020
@faily-bot

faily-botBot commented Aug 10, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31579: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\ObjectStore\ObjectStoreStorageTest::testPartFile
Failed asserting that false matches expected 'bar'.
/drone/src/tests/lib/Files/Storage/Storage.php:645

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - this is injected into the constructor of the Table object 👍

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable19

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable18

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable17

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@MorrisJobke@ChristophWurst