Uh oh!
There was an error while loading. Please reload this page.
Delete old birthday calendar object when moving contact to another ad… - #22201
Merged
skjnldsv merged 1 commit intoMar 26, 2021
Conversation
cweiske
commented
Aug 14, 2020
ContributorAuthor
I only added the signoff line to the commit message. |
bj-github
commented
Mar 16, 2021
Sorry, it has been a while and I was just wondering when this might filter up to a release please? I'd like to cross it off my list (i.e., know I can do some more shuffling/reorganising of my Addressbooks). With thanks in anticipation - B. |
tcitworld
requested review from
ChristophWurst, juliusknorr and skjnldsv
and removed request for
georgehrkeMarch 16, 2021 07:56
skjnldsv
commented
Mar 25, 2021
Member
Rebased |
skjnldsv
commented
Mar 25, 2021
Member
/backport to stable20 |
skjnldsv
commented
Mar 25, 2021
Member
/backport to stable21 |
skjnldsv
commented
Mar 25, 2021
Member
/backport to stable19 |
ChristophWurst
approved these changes
Mar 25, 2021
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Lots of psalm issues though :/
skjnldsv
commented
Mar 25, 2021
Member
Pushed a fix for it and for the unit tests, let's see |
bj-github
commented
Mar 25, 2021
Thank you, especially for the move to back-port it! |
Member
Pushed a cs/psalm fix! acceptance failure is unrelated and also on master |
…dress book When an contact is moved to another address book, the contact is copied to the second address book. During copying, the birthday event is created - but it gets the same UID as the contact's birthday event in the first address book. To prevent the "Calendar object with uid already exists" error that followed, we need to delete the old entry before the new one is created. Resolves: #20492 Signed-off-by: Christian Weiske <cweiske@cweiske.de>
skjnldsv
commented
Mar 26, 2021
Member
/backport to stable21 |
skjnldsv
commented
Mar 26, 2021
Member
/backport to stable19 |
This was referenced Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dress book
When an contact is moved to another address book, the contact is copied to
the second address book.
During copying, the birthday event is created - but it gets the same UID
as the contact's birthday event in the first address book.
To prevent the "Calendar object with uid already exists" error that followed,
we need to delete the old entry before the new one is created.
Resolves: #20492