Skip to content

Use user mount with matching shared storage only - #22234

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/reshare-mount
Sep 10, 2020
Merged

Use user mount with matching shared storage only#22234
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/reshare-mount

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 13, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This is the result of some extensive log statements, I could not yet reproduce the issue locally.

@juliusknorr
juliusknorrforce-pushed the bugfix/noid/reshare-mount branch from 4d3ddbf to abbab5cCompareAugust 13, 2020 12:08
@faily-bot

This comment has been minimized.

Sign in to view
@juliusknorrjuliusknorr added 3. to review Waiting for reviews bug labels Aug 13, 2020
@juliusknorr
Use user mount with matching shared storage only
52eff4a
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the bugfix/noid/reshare-mount branch from abbab5c to 52eff4aCompareAugust 13, 2020 13:10
@juliusknorr
juliusknorr marked this pull request as ready for review August 14, 2020 09:17
@juliusknorr

juliusknorr commented Aug 14, 2020

Copy link
Copy Markdown
MemberAuthor

It is confirmed to fix the issue on the affected instance, but i could still not reproduce it anywhere

@MorrisJobkeMorrisJobke added this to the Nextcloud 20 milestone Aug 14, 2020
@MorrisJobke

MorrisJobke commented Aug 14, 2020

Copy link
Copy Markdown
Member

/backport to stable19

MorrisJobke
MorrisJobke approved these changes Aug 14, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

This was referenced Aug 21, 2020
Merged
Merged
@rullzerrullzer mentioned this pull request Sep 3, 2020
Merged
13 tasks
@juliusknorr

juliusknorr commented Sep 4, 2020

Copy link
Copy Markdown
MemberAuthor

🏓 for reviews :)

@MorrisJobke

MorrisJobke commented Sep 10, 2020

Copy link
Copy Markdown
Member

🏓 again

rullzer
rullzer approved these changes Sep 10, 2020
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.... 🐘

@MorrisJobke
MorrisJobke merged commit e269f15 into masterSep 10, 2020
@MorrisJobke
MorrisJobke deleted the bugfix/noid/reshare-mount branch September 10, 2020 14:19
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 10, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@icewind1991icewind1991Awaiting requested review from icewind1991
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@MorrisJobke@rullzer