Skip to content

[stable19] Delete chunks if the move on an upload failed - #22239

Merged
nickvergessen merged 3 commits into
stable19from
backport/22128/stable19
Aug 19, 2020
Merged

[stable19] Delete chunks if the move on an upload failed#22239
nickvergessen merged 3 commits into
stable19from
backport/22128/stable19

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #22128

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@faily-bot

faily-botBot commented Aug 13, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31765: failure

mysql8.0-php7.2

Show full log
There was 1 error:
1) Test\Files\ObjectStore\ObjectStoreStorageTest::testHash with data set #1 ('Foobar', 'sha1')
hash_update_stream() expects parameter 2 to be resource, boolean given
/drone/src/lib/private/Files/Storage/Common.php:259
/drone/src/tests/lib/Files/Storage/Storage.php:443

integration-provisioning-v2

  • build/integration/features/provisioning-v2.feature:22
Show full log
 Scenario: Searching by displayname in groups # /drone/src/build/integration/features/provisioning-v2.feature:22
Given As an "admin" # FeatureContext::asAn()
[Thu Aug 13 19:05:31 2020] 127.0.0.1:51396 [404]: /ocs/v2.php/cloud/users/user-in-group
[Thu Aug 13 19:05:32 2020] 127.0.0.1:51416 [200]: /ocs/v2.php/cloud/users
[Thu Aug 13 19:05:32 2020] 127.0.0.1:51476 [200]: /ocs/v2.php/cloud/users/user-in-group
[Thu Aug 13 19:05:33 2020] 127.0.0.1:51504 [200]: /ocs/v2.php/cloud/users/user-in-group
And user "user-in-group" with displayname "specific-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Thu Aug 13 19:05:33 2020] 127.0.0.1:51524 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Thu Aug 13 19:05:34 2020] 127.0.0.1:51544 [200]: /ocs/v2.php/cloud/users
[Thu Aug 13 19:05:34 2020] 127.0.0.1:51586 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Thu Aug 13 19:05:34 2020] 127.0.0.1:51604 [200]: /ocs/v2.php/cloud/users/user-in-group2
And user "user-in-group2" with displayname "another-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Thu Aug 13 19:05:34 2020] 127.0.0.1:51626 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Thu Aug 13 19:05:35 2020] 127.0.0.1:51640 [200]: /ocs/v2.php/cloud/users
[Thu Aug 13 19:05:35 2020] 127.0.0.1:51680 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Thu Aug 13 19:05:36 2020] 127.0.0.1:51710 [200]: /ocs/v2.php/cloud/users/user-not-in-group
And user "user-not-in-group" with displayname "specific-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Thu Aug 13 19:05:36 2020] 127.0.0.1:51738 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Thu Aug 13 19:05:37 2020] 127.0.0.1:51758 [200]: /ocs/v2.php/cloud/users
[Thu Aug 13 19:05:37 2020] 127.0.0.1:51784 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Thu Aug 13 19:05:37 2020] 127.0.0.1:51804 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
And user "user-not-in-group2" with displayname "another-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Thu Aug 13 19:05:38 2020] 127.0.0.1:51822 [404]: /ocs/v2.php/cloud/groups/group-search
[Thu Aug 13 19:05:38 2020] 127.0.0.1:51836 [200]: /ocs/v2.php/cloud/groups
[Thu Aug 13 19:05:38 2020] 127.0.0.1:51850 [200]: /ocs/v2.php/cloud/groups/group-search
And group "group-search" exists # FeatureContext::assureGroupExists()
[Thu Aug 13 19:05:39 2020] 127.0.0.1:51870 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Thu Aug 13 19:05:39 2020] 127.0.0.1:51896 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Thu Aug 13 19:05:39 2020] 127.0.0.1:51926 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
And user "user-in-group" belongs to group "group-search" # FeatureContext::assureUserBelongsToGroup()
[Thu Aug 13 19:05:40 2020] 127.0.0.1:52022 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Thu Aug 13 19:05:43 2020] 127.0.0.1:52050 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Thu Aug 13 19:05:43 2020] 127.0.0.1:52148 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
And user "user-in-group2" belongs to group "group-search" # FeatureContext::assureUserBelongsToGroup()
[Thu Aug 13 19:05:43 2020] 127.0.0.1:52172 [200]: /ocs/v2.php/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi
When sending "GET" to "/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi" # FeatureContext::sendingTo()
Then the OCS status code should be "200" # FeatureContext::theOCSStatusCodeShouldBe()
And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
And detailed users returned are # FeatureContext::theDetailedUsersShouldBe()
| user-in-group |
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'user-in-group'
[Thu Aug 13 19:05:44 2020] 127.0.0.1:52200 [200]: /ocs/v2.php/cloud/users/user-in-group
[Thu Aug 13 19:05:44 2020] 127.0.0.1:52228 [404]: /ocs/v2.php/cloud/users/user-in-group
[Thu Aug 13 19:05:45 2020] 127.0.0.1:52258 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Thu Aug 13 19:05:45 2020] 127.0.0.1:52344 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Thu Aug 13 19:05:46 2020] 127.0.0.1:52374 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Thu Aug 13 19:05:46 2020] 127.0.0.1:52414 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Thu Aug 13 19:05:46 2020] 127.0.0.1:52444 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Thu Aug 13 19:05:47 2020] 127.0.0.1:52524 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Thu Aug 13 19:05:47 2020] 127.0.0.1:52584 [200]: /ocs/v2.php/cloud/groups/group-search
[Thu Aug 13 19:05:47 2020] 127.0.0.1:52656 [404]: /ocs/v2.php/cloud/groups/group-search
[Thu Aug 13 19:05:47 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Thu Aug 13 19:05:47 2020] 127.0.0.1:52666 [401]: /remote.php/webdav/myFileToComment.txt
[Thu Aug 13 19:05:48 2020] 127.0.0.1:52670 [207]: /remote.php/dav/systemtags/
[Thu Aug 13 19:05:48 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Thu Aug 13 19:05:48 2020] 127.0.0.1:52694 [401]: /remote.php/webdav/myFileToTag.txt
[Thu Aug 13 19:05:48 2020] 127.0.0.1:52702 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Thu Aug 13 19:05:49 2020] 127.0.0.1:52770 [404]: /remote.php/dav/calendars/admin/MyCalendar

@rullzerrullzer added the 3. to review Waiting for reviews label Aug 14, 2020
@rullzerrullzer mentioned this pull request Aug 18, 2020
1 task

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 19, 2020
@nickvergessen
nickvergessen merged commit fef5925 into stable19Aug 19, 2020
@nickvergessen
nickvergessen deleted the backport/22128/stable19 branch August 19, 2020 13:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@nickvergessen@juliusknorr