Skip to content

Fix some MissingDocblockType or InvalidDocblock warnings. - #22253

Merged
MorrisJobke merged 2 commits into
masterfrom
debt/noid/docblocks
Aug 17, 2020
Merged

Fix some MissingDocblockType or InvalidDocblock warnings.#22253
MorrisJobke merged 2 commits into
masterfrom
debt/noid/docblocks

Conversation

@kesselb

@kesselbkesselb commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Fix some InvalidDocblock and MissingDocblockType warnings found by psalm.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
use OCP\Files\SimpleFS\ISimpleFolder;
use OCP\ILogger;
use Sabre\CardDAV\Card;
use Sabre\VObject\Parameter;

@kesselbkesselbAug 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import class for

/** @var Parameter $typeParam */

@kesselbkesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 14, 2020
@kesselbkesselb added this to the Nextcloud 20 milestone Aug 14, 2020

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@MorrisJobke

Copy link
Copy Markdown
Member

Fix some InvalidDocblock and MissingDocblockType warnings found by psalm.

#21787

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - makes sense 🙈

@faily-bot

faily-botBot commented Aug 14, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31823: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
│ Details view in Files app visibility could not be got
│ Exception message: Element not found with xpath, (//html//*[@id="app-sidebar" or contains(@class, 'app-sidebar')])[1]
│ │ Unable to locate element: {"method":"xpath","selector":"(//html//*[@id=\"app-sidebar\" or contains(@class, 'app-sidebar')])[1]"}
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: '5d8e954bb303', ip: '172.25.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@MorrisJobke

Copy link
Copy Markdown
Member

Please review :)

@MorrisJobke
MorrisJobke merged commit 00cb8e6 into masterAug 17, 2020
@MorrisJobke
MorrisJobke deleted the debt/noid/docblocks branch August 17, 2020 15:45
<?php
/** @var $l \OCP\IL10N */
/** @var $_ array */
/** @var \OCP\IL10N $_ */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@MorrisJobke@ChristophWurst