Skip to content

Properly add new methods to interface and document in PHPDoc for getR… - #22271

Merged
rullzer merged 1 commit into
masterfrom
phpdoc/22063/add-interface-method-and-phpdoc
Aug 17, 2020
Merged

Properly add new methods to interface and document in PHPDoc for getR…#22271
rullzer merged 1 commit into
masterfrom
phpdoc/22063/add-interface-method-and-phpdoc

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

…ootMounts()

Introduced in #22063 and was just forgotten.

Found by Psalm in #21578 and avoids to add the typehint in the calling place \o/

…ootMounts()
Introduced in #22063 and was just forgotten.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 17, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 20 milestone Aug 17, 2020
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2020
@faily-bot

faily-botBot commented Aug 17, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31857: failure

samba

Show full log
There was 1 failure:
1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
[0] => OC\Files\Notify\Change Object
(
[type:OC\Files\Notify\Change:private] => 1
[path:OC\Files\Notify\Change:private] => newfile.txt
)
[1] => OC\Files\Notify\RenameChange Object
(
[targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
[type:OC\Files\Notify\Change:private] => 4
[path:OC\Files\Notify\Change:private] => newfile.txt
)
[2] => OC\Files\Notify\Change Object
(
[type:OC\Files\Notify\Change:private] => 2
[path:OC\Files\Notify\Change:private] => renamed.txt
)
)
Failed asserting that an array contains OC\Files\Notify\RenameChange Object &00000000192631a70000000059f7b169 (
'targetPath' => 'renamed.txt'
'type' => 4
'path' => 'newfile.txt'
).
/drone/src/apps/files_external/tests/Storage/SmbTest.php:126

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@rullzer
rullzer merged commit 6675528 into masterAug 17, 2020
@rullzer
rullzer deleted the phpdoc/22063/add-interface-method-and-phpdoc branch August 17, 2020 17:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke@rullzer@nickvergessen@blizzz@skjnldsv