Skip to content

Move contactsmenu to vue - #22274

Closed
dk1a wants to merge 1 commit into
nextcloud:masterfrom
dk1a:move_contactsmenu_to_vue
Closed

Move contactsmenu to vue#22274
dk1a wants to merge 1 commit into
nextcloud:masterfrom
dk1a:move_contactsmenu_to_vue

Conversation

@dk1a

@dk1adk1a commented Aug 17, 2020•
edited
Loading

Copy link
Copy Markdown

Fix#12905
Fix#17483
Signed-off-by: Kirill Dmitriev dk1a@protonmail.com

@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from 4f10fe4 to 2d5fca4CompareAugust 17, 2020 20:01
@skjnldsvskjnldsv added this to the Nextcloud 21 milestone Aug 17, 2020
skjnldsv
skjnldsv reviewed Aug 17, 2020
View reviewed changes
Comment threadcore/src/OC/contactsmenu/App.vue Outdated
skjnldsv
skjnldsv reviewed Aug 17, 2020
View reviewed changes
Comment threadcore/src/OC/contactsmenu/Contact.vue
skjnldsv
skjnldsv reviewed Aug 17, 2020
View reviewed changes
Comment threadcore/src/init.js Outdated
@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from 2d5fca4 to a7ce86bCompareAugust 19, 2020 07:26
@dk1a

dk1a commented Aug 19, 2020

Copy link
Copy Markdown
Author

I moved the styles to vue components, but also left them in styles.scss, since it seems required by the jquery version of contactsmenu, not sure what to do with that one

@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from a7ce86b to e9d6ac8CompareAugust 19, 2020 07:51
skjnldsv
skjnldsv reviewed Aug 19, 2020
View reviewed changes
Comment threadcore/src/components/ContactsMenu/Contact.vue Outdated
skjnldsv
skjnldsv reviewed Aug 19, 2020
View reviewed changes
Comment threadcore/src/views/ContactsMenu.vue Outdated
skjnldsv
skjnldsv reviewed Aug 19, 2020
View reviewed changes
Comment threadcore/src/views/ContactsMenu.vue Outdated
@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from e9d6ac8 to 0519568CompareAugust 20, 2020 06:16
skjnldsv
skjnldsv reviewed Aug 20, 2020
View reviewed changes
Comment threadcore/src/components/ContactsMenu/Contact.vue Outdated
skjnldsv
skjnldsv requested changes Aug 20, 2020
View reviewed changes
Comment threadcore/src/views/ContactsMenu.vue Outdated
Comment threadcore/src/views/ContactsMenu.vue Outdated
Comment threadcore/src/views/ContactsMenu.vue

onInput: debounce(function(query) {
// load contacts on input
this.loadContacts()

@skjnldsvskjnldsvAug 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to comply to the min search length

server/lib/private/Contacts/ContactsMenu/Manager.php

Line 66 in 7c56283

$minSearchStringLength = $this->config->getSystemValueInt('sharing.minSearchStringLength', 0);

@dk1adk1aAug 25, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this in a previous commit; though is it intended that with minSearchStringLength>0 the contacts menu will be empty initially? That's how the backend did it, so I copied the behavior to frontend

Comment threadcore/src/views/ContactsMenu.vue Outdated
@jancborchardt

jancborchardt commented Aug 20, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Very very cool @dk1a! :) Awesome that you are looking at the Contacts menu.

Opened a new issue with possible further enhancements which we had in mind for some time – the Vue rewrite could be a good base for this! #22329

@skjnldsv

skjnldsv commented Aug 20, 2020

Copy link
Copy Markdown
Member

If you use the contacts vcf url and add ?photo at the end, it will try to fetch the avatar.
Could be a nice combo with the Avatar component (that will fallback to a placeholder if the avatar image load fails)
ref #17483

@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from 0519568 to 4f68cb1CompareAugust 20, 2020 20:47
@dk1a

dk1a commented Aug 20, 2020

Copy link
Copy Markdown
Author

If you use the contacts vcf url and add ?photo at the end, it will try to fetch the avatar.
Could be a nice combo with the Avatar component (that will fallback to a placeholder if the avatar image load fails)
ref #17483

Contacts already returned an avatar image, it just didn't work on the backend - fixed it

@dk1adk1a mentioned this pull request Aug 20, 2020
Closed
2 tasks
skjnldsv
skjnldsv reviewed Aug 21, 2020
View reviewed changes
Comment threadapps/accessibility/css/dark.scss Outdated
#app-navigation > ul > li > a:first-child,
#app-navigation > ul > li > ul > li > a:first-child,
#contactsmenu-menu a,
.contacts-menu__contacts-list a,

@skjnldsvskjnldsvAug 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it directly in the ContactsMenu.
Use body.theme--dark to narrow the selector :)

@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch 2 times, most recently from b6185d2 to 00d779aCompareAugust 21, 2020 21:17
@skjnldsvskjnldsv linked an issue Aug 25, 2020 that may be closed by this pull request
Vue contacts menu #15586
Closed
@skjnldsv

skjnldsv commented Aug 25, 2020

Copy link
Copy Markdown
Member

Any news @dk1a ? :)

@dk1a
Move contactsmenu to vue
0a1a987
Signed-off-by: Kirill Dmitriev <dk1a@protonmail.com>
@dk1a
dk1aforce-pushed the move_contactsmenu_to_vue branch from 00d779a to 0a1a987CompareAugust 25, 2020 18:17
@dk1a

dk1a commented Aug 25, 2020

Copy link
Copy Markdown
Author

I'd added min search length, moved dark style;
was also going to look at what other apps do with contactsmenu sometime this week.
Test failures seem unrelated, are they a problem?

@skjnldsv

skjnldsv commented Aug 31, 2020

Copy link
Copy Markdown
Member

Jsunit is legit.
Node / build too :)

@jancborchardt

jancborchardt commented Sep 15, 2020

Copy link
Copy Markdown
Member

added min search length

Do we really want min search length? UX wise it’s always a bit of a hassle, and the current Contacts menu doesn’t have any minimum either.

@skjnldsv

skjnldsv commented Sep 15, 2020

Copy link
Copy Markdown
Member

Do we really want min search length? UX wise it’s always a bit of a hassle, and the current Contacts menu doesn’t have any minimum either.

we have it everywhere. Unified search, sharing, contactsmenu... etc

@skjnldsv

skjnldsv commented Nov 7, 2020

Copy link
Copy Markdown
Member

Hey! Any news on this? :)
Now that we are into 21, could you rebase?
If you want to join, we have a community channel where we chat 😉
Are you interested?

@skjnldsvskjnldsv mentioned this pull request Nov 13, 2020
Merged
This was referenced Dec 14, 2020
Merged
Merged
@ChristophWurst

ChristophWurst commented Dec 22, 2020

Copy link
Copy Markdown
Member

Now that we are into 21, could you rebase?

We're in beta now. I'd say let's get this in in a few weeks when 21 was branched off. @dk1a could you please rebase and rebuild your branch to resolve the conflicts? Thanks ✌️

@MorrisJobkeMorrisJobke mentioned this pull request May 20, 2021
Merged
@MorrisJobke

MorrisJobke commented May 20, 2021

Copy link
Copy Markdown
Member

Let's close this for now. We can reopen it at any time again, but this one here just didn't got any update recently.

@szaimen

szaimen commented May 20, 2021

Copy link
Copy Markdown
Contributor

@MorrisJobke May I suggest to just get rid of the contacts menu now that we have unified search?

@MorrisJobke

MorrisJobke commented May 21, 2021

Copy link
Copy Markdown
Member

@MorrisJobke May I suggest to just get rid of the contacts menu now that we have unified search?

cc @skjnldsv@ChristophWurst

@skjnldsvskjnldsv mentioned this pull request Nov 26, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv requested changes

Assignees

No one assigned

Labels

2. developingWork in progressenhancementfeature: contacts menutechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

contact search: Avatar images doesn't show up Vue contacts menu Move contactsmenu to vue

6 participants

@dk1a@jancborchardt@skjnldsv@ChristophWurst@MorrisJobke@szaimen