Skip to content

Change color of displayname and ellipsis status message - #22317

Merged
georgehrke merged 1 commit into
masterfrom
bugfix/noid/status_ellipsis
Aug 21, 2020
Merged

Change color of displayname and ellipsis status message#22317
georgehrke merged 1 commit into
masterfrom
bugfix/noid/status_ellipsis

Conversation

@georgehrke

Copy link
Copy Markdown
Member

Signed-off-by: Georg Ehrke developer@georgehrke.com

BeforeAfter
8C59817F-ADDD-4EE0-A5AD-D6A08911E4C0BFBE6BA4-F93F-43A0-BC05-892BD76617DD

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a title attribute on the ellipsised text to show the full status on hover?

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a title attribute on the ellipsised text to show the full status on hover?

@georgehrke

georgehrke commented Aug 20, 2020

Copy link
Copy Markdown
MemberAuthor

Maybe add a title attribute on the ellipsised text to show the full status on hover?

We are using the Actions component here, so this needs to be done upstream in nc/vue.

Nevermind, fixed here.

@georgehrke
georgehrkeforce-pushed the bugfix/noid/status_ellipsis branch from 393a34e to 5ad9cbaCompareAugust 20, 2020 08:56
@jancborchardt

jancborchardt commented Aug 20, 2020

Copy link
Copy Markdown
Member

Maybe add a title attribute on the ellipsised text to show the full status on hover?

I wouldn’t do that, we shouldn’t have tooltips all over (e.g. we also removed them from the avatars in Mail as it made no sense). When one wants to check the full message, they can go to the "Set custom status" dialog – and it’s their status in the first place. :) @georgehrke otherwise it looks good!

@rullzerrullzer mentioned this pull request Aug 21, 2020
19 tasks
@georgehrke

Copy link
Copy Markdown
MemberAuthor

let me rebase

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the bugfix/noid/status_ellipsis branch from 5ad9cba to d7a1c01CompareAugust 21, 2020 09:17
@georgehrkegeorgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 21, 2020
@faily-bot

faily-botBot commented Aug 21, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32170: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\MoveFromCacheTraitTest::testSearchQueryByTag
Failed asserting that 0 matches expected 3.
/drone/src/tests/lib/Files/Cache/CacheTest.php:363

mariadb10.4-php7.3

Show full log
There was 1 error:
1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSameUriSameIdForDifferentCalendarTypes
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790
/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:50
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/tests/unit/CalDAV/AbstractCalDavBackend.php:153
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:916
--
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

acceptance-header

  • tests/acceptance/features/header.feature:31
Show full log
 Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section of the "Administration" group # AppNavigationContext::iOpenTheSectionOf()
And I enable restricting username autocompletion to groups # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
And I see that username autocompletion is restricted to groups # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
Failed asserting that true is false.
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@georgehrke

Copy link
Copy Markdown
MemberAuthor

Failures unrelated, merging.

@georgehrke
georgehrke merged commit e212862 into masterAug 21, 2020
@georgehrke
georgehrke deleted the bugfix/noid/status_ellipsis branch August 21, 2020 12:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@georgehrke@jancborchardt@nickvergessen@tcitworld@marcoambrosini